Bug 888149 – [guru] x11-misc/gromit-mpx-1.4.3 fails to compile (CLANG-STRICTER-SYSTEM): gromit-mpx.c:862:14: error: call to undeclared function app_parse_args; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

• Status: RESOLVED FIXED
• Product: GURU

[Description Agostino Sarubbo 2022-12-24 09:13:14 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-misc/gromit-mpx-1.4.3 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-24 09:13:16 UTC]

Created attachment 844841 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-12-24 09:13:17 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


--   Package 'ayatana-appindicator3-0.1', required by 'virtual:world', not found
FAILED: CMakeFiles/gromit-mpx.dir/src/gromit-mpx.c.o 
/var/tmp/portage/x11-misc/gromit-mpx-1.4.3/work/gromit-mpx-1.4.3/src/gromit-mpx.c:862:14: error: call to undeclared function 'app_parse_args'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

[Comment 3 Oliver Freyermuth 2022-12-24 17:39:34 UTC]

Thanks for the report!

I've PRed a fix for this to upstream right now:
https://github.com/bk138/gromit-mpx/pull/173

I'll let this PR be open for a few days and see if there are change requests, if there's no response, I'll add a downstream patch for Gentoo based on that PR.

[Comment 4 Oliver Freyermuth 2022-12-24 21:26:32 UTC]

Upstream accepted my PR already, so I added this as a downstream patch which can be dropped again for the next release. Committed as:
https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=2f60169115bada72bbf046a698cc901d8d7384ac

The issue will be close automatically once it's merged from guru-dev into master.

[Comment 5 Larry the Git Cow 2022-12-27 08:05:45 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2f60169115bada72bbf046a698cc901d8d7384ac

commit 2f60169115bada72bbf046a698cc901d8d7384ac
Author:     Oliver Freyermuth <[e-mail]>
AuthorDate: 2022-12-24 21:24:04 +0000
Commit:     Oliver Freyermuth <[e-mail]>
CommitDate: 2022-12-24 21:24:04 +0000

    x11-misc/gromit-mpx: Fix implicit function declaration.
    
    This fixes compilation with -Werror,-Wimplicit-function-declaration.
    
    Closes: https://bugs.gentoo.org/888149
    Signed-off-by: Oliver Freyermuth <[e-mail]>

 .../gromit-mpx-1.4.3-fwd-declare-app_parse_args.patch    | 16 ++++++++++++++++
 x11-misc/gromit-mpx/gromit-mpx-1.4.3.ebuild              |  4 ++++
 2 files changed, 20 insertions(+)