Bug 888043 – sys-kernel/gentoo-sources-6.1.1 fails make bzImage complaining about implicit functions due to -Werror=implicit-function-declaration

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benjamin Réveillé 2022-12-22 22:45:34 UTC]

buikdig kernel with genkernel fails complaining about implicit functions:

*         >> Kernel version has not changed since genkernel start
*         >> Compiling 6.1.1-gentoo-x86_64 bzImage ...
COMMAND: nice -n10 make -j17 ARCH='x86' AS='x86_64-pc-linux-gnu-as' AR='x86_64-pc-linux-gnu-ar' CC='x86_64-pc-linux-gnu-gcc' LD='x86_64-pc-linux-gnu-ld' NM='x86_64-pc-linux-gnu-nm' OBJCOPY='x86_64-pc-linux-gnu-objcopy' OBJDUMP='x86_64-pc-linux-gnu-objdump' READELF='x86_64-pc-linux-gnu-readelf' STRIP='x86_64-pc-linux-gnu-strip' HOSTAR='x86_64-pc-linux-gnu-ar' HOSTCC='x86_64-pc-linux-gnu-gcc' HOSTCXX='x86_64-pc-linux-gnu-g++' HOSTLD='x86_64-pc-linux-gnu-ld' bzImage
  DESCEND objtool
  CALL    scripts/checksyscalls.sh
  CC      kernel/sched/build_utility.o
  CC      kernel/module/main.o
  CC      kernel/module/strict_rwx.o
  CC      kernel/time/time.o
  CC      kernel/time/timer.o
  CC      kernel/time/hrtimer.o
  CC      kernel/time/timekeeping.o
  CC      kernel/time/ntp.o
  CC      kernel/futex/core.o
  CC      kernel/module/tree_lookup.o
  CC      kernel/module/kallsyms.o
  CC      kernel/module/procfs.o
In file included from kernel/sched/build_utility.c:99:
kernel/sched/psi.c: In function 'psi_cgroup_restart':
kernel/sched/psi.c:1136:17: error: implicit declaration of function 'rq_lock_irq'; did you mean 'rq_unlock_irq'? [-Werror=implicit-function-declaration]
 1136 |                 rq_lock_irq(rq, &rf);
      |                 ^~~~~~~~~~~
      |                 rq_unlock_irq
  CC      kernel/module/sysfs.o
  CC      kernel/cgroup/cgroup.o
  CC      kernel/cgroup/rstat.o
  CC      kernel/cgroup/namespace.o
  CC      kernel/cgroup/cgroup-v1.o
  CC      kernel/time/clocksource.o
  CC      kernel/futex/syscalls.o
  CC      kernel/time/jiffies.o
  CC      kernel/time/timer_list.o
  CC      kernel/time/timeconv.o
  CC      kernel/trace/trace_clock.o
  AR      kernel/module/built-in.a
  CC      kernel/cgroup/freezer.o
  CC      kernel/bpf/core.o
  CC      kernel/events/core.o
  CC      kernel/trace/ring_buffer.o
  CC      kernel/bpf/trampoline.o
  CC      kernel/time/timecounter.o
  CC      kernel/trace/trace.o
  CC      kernel/trace/trace_output.o
  CC      kernel/time/alarmtimer.o
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:250: kernel/sched/build_utility.o] Error 1
make[2]: *** [scripts/Makefile.build:500: kernel/sched] Error 2
make[2]: *** Waiting for unfinished jobs....
  CC      kernel/time/posix-timers.o
  CC      kernel/trace/trace_seq.o
  CC      kernel/trace/trace_stat.o
  CC      kernel/futex/pi.o
  CC      kernel/bpf/dispatcher.o
  CC      kernel/trace/trace_printk.o
  CC      kernel/futex/requeue.o
  CC      kernel/futex/waitwake.o
  CC      kernel/trace/pid_list.o
  CC      kernel/events/ring_buffer.o
  CC      kernel/events/callchain.o
  CC      kernel/events/hw_breakpoint.o
  CC      kernel/trace/trace_sched_switch.o
  CC      kernel/trace/trace_nop.o
  CC      kernel/trace/blktrace.o
  CC      kernel/time/posix-cpu-timers.o
  CC      kernel/time/posix-clock.o
  AR      kernel/futex/built-in.a
  CC      kernel/trace/trace_events.o
  CC      kernel/events/uprobes.o
  CC      kernel/time/itimer.o
  CC      kernel/trace/trace_export.o
  AR      kernel/cgroup/built-in.a
  CC      kernel/trace/trace_event_perf.o
  CC      kernel/trace/trace_events_filter.o
  CC      kernel/trace/trace_events_trigger.o
  CC      kernel/trace/trace_eprobe.o
  CC      kernel/time/clockevents.o
  CC      kernel/time/tick-common.o
  CC      kernel/time/tick-broadcast.o
  AR      kernel/bpf/built-in.a
  CC      kernel/trace/trace_kprobe.o
  CC      kernel/trace/error_report-traces.o
  CC      kernel/time/tick-broadcast-hrtimer.o
  CC      kernel/trace/power-traces.o
  CC      kernel/trace/rpm-traces.o
  CC      kernel/time/tick-oneshot.o
  CC      kernel/trace/trace_dynevent.o
  CC      kernel/trace/trace_probe.o
  CC      kernel/time/tick-sched.o
  CC      kernel/time/vsyscall.o
  CC      kernel/trace/trace_uprobe.o
  CC      kernel/trace/rethook.o
  CC      kernel/time/timekeeping_debug.o
  CC      kernel/time/namespace.o
  CC      drivers/cpufreq/amd-pstate.o
  CC      drivers/cpufreq/amd-pstate-trace.o
  CC      drivers/cpufreq/amd-pstate-ut.o
  AR      kernel/time/built-in.a
  AR      drivers/cpufreq/built-in.a
  AR      drivers/built-in.a
  AR      kernel/events/built-in.a
  AR      kernel/trace/built-in.a
make[1]: *** [scripts/Makefile.build:500: kernel] Error 2
make: *** [Makefile:1992: .] Error 2

* ERROR: compile_kernel(): compile_generic() failed to compile the "bzImage" target!
* Please consult '/var/log/genkernel.log' for more information and any
* errors that were reported above.
* 
* Report any genkernel bugs to bugs.gentoo.org and
* assign your bug to [e-mail]. Please include
* as much information as you can in your bug report; attaching
* '/var/log/genkernel.log' so that your issue can be dealt with effectively.
* 
* Please do *not* report kernel compilation failures as genkernel bugs!
* 

* mount: >> Boot partition state on '/boot' was not changed; Skipping restore boot partition state ...
>>> Ended on: 2022-12-22 23:09:57 (after 0 days 0 hours 00 minutes 13 seconds)


This is because KBUILD_CFLAGS contains -Werror=implicit-function-declaration

[Comment 1 Sam James 2022-12-22 22:48:08 UTC]

>This is because KBUILD_CFLAGS contains -Werror=implicit-function-declaration

Right, but they're serious warnings which can lead to runtime problems, so it's good that it does :)

[Comment 2 Mike Pagano 2022-12-22 22:51:07 UTC]

Can you unset CONFIG_PSI:

# CONFIG_PSI is not set

And then re-run the build ?

[Comment 3 Benjamin Réveillé 2022-12-22 23:35:29 UTC]

(In reply to Mike Pagano from comment #2)
> Can you unset CONFIG_PSI:
> 
> # CONFIG_PSI is not set
> 
> And then re-run the build ?

It builds that way :-) (but I guess it just hides the issue which remains)

[Comment 4 Benjamin Réveillé 2022-12-23 20:06:52 UTC]

Created attachment 844809 [details, diff]
rq_locl_irq decleration patch for gentoo-sources-6.1.1

Just drop it into /etc/portage/patches/sys-kernel/gentoo-sources-6.1.1

[Comment 5 Mike Pagano 2022-12-23 20:39:33 UTC]

(In reply to Benjamin Réveillé from comment #4)
> Created attachment 844809 [details, diff] [details, diff]
> rq_locl_irq decleration patch for gentoo-sources-6.1.1
> 
> Just drop it into /etc/portage/patches/sys-kernel/gentoo-sources-6.1.1

Any issues booting with this ?

[Comment 6 Benjamin Réveillé 2022-12-24 17:29:30 UTC]

(In reply to Mike Pagano from comment #5)
> (In reply to Benjamin Réveillé from comment #4)
> > Created attachment 844809 [details, diff] [details, diff] [details, diff]
> > rq_locl_irq decleration patch for gentoo-sources-6.1.1
> > 
> > Just drop it into /etc/portage/patches/sys-kernel/gentoo-sources-6.1.1
> 
> Any issues booting with this ?

No, no issue at all.

[Comment 7 Larry the Git Cow 2022-12-31 15:58:54 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1b400b5cf7f4cfb1c0059d65beee9e6542b5b6d

commit b1b400b5cf7f4cfb1c0059d65beee9e6542b5b6d
Author:     Mike Pagano <[e-mail]>
AuthorDate: 2022-12-31 15:58:12 +0000
Commit:     Mike Pagano <[e-mail]>
CommitDate: 2022-12-31 15:58:12 +0000

    sys-kernel/gentoo-sources: add 6.1.2
    
    Fix for BMQ Patch
    Closes: https://bugs.gentoo.org/888043
    
    Signed-off-by: Mike Pagano <[e-mail]>

 sys-kernel/gentoo-sources/Manifest                 |  3 +++
 .../gentoo-sources/gentoo-sources-6.1.2.ebuild     | 28 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)