Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 888031 - [guru] sys-fs/gfs2-utils-3.5.1 overwrites user's optimization (-O*)
Summary: [guru] sys-fs/gfs2-utils-3.5.1 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andrea Postiglione
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-22 19:20 UTC by Agostino Sarubbo
Modified: 2024-11-21 09:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,199.00 KB, text/plain)
2022-12-22 19:20 UTC, Agostino Sarubbo
Details
successeful gffs2-utils-3.5.1.build.log (gfs2-utils-3.5.1:20241120-235136.log.gz,37.67 KB, application/gzip)
2024-11-21 00:02 UTC, Fat-Zer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-22 19:20:33 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/gfs2-utils-3.4.1 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-22 19:20:35 UTC
Created attachment 844783 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2024-11-15 16:09:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=1390b23f46a1e80620fea4ed7f27866ba4c6de67

commit 1390b23f46a1e80620fea4ed7f27866ba4c6de67
Author:     Alexander Golubev <fatzer2@gmail.com>
AuthorDate: 2024-11-15 00:27:37 +0000
Commit:     Alexander Golubev <fatzer2@gmail.com>
CommitDate: 2024-11-15 00:27:37 +0000

    sys-fs/gfs2-utils: add 3.5.1
    
    Bug: https://bugs.gentoo.org/888029
    Bug: https://bugs.gentoo.org/888031
    Signed-off-by: Alexander Golubev <fatzer2@gmail.com>

 sys-fs/gfs2-utils/Manifest                |  1 +
 sys-fs/gfs2-utils/gfs2-utils-3.5.1.ebuild | 58 +++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 3 Agostino Sarubbo gentoo-dev 2024-11-16 16:22:50 UTC
guru_ci has reproduced this issue with version 3.5.1 - Updating summary.
Comment 4 Fat-Zer 2024-11-21 00:02:08 UTC
Created attachment 910903 [details]
successeful gffs2-utils-3.5.1.build.log

I believe I've already fixed this issue. Could anybody help me why CI still complains about 3.5.1?

Here is a build log with CC="clang" CFLAGS="-O3", which doesn't show any additional CFLAGS.
Comment 5 Agostino Sarubbo gentoo-dev 2024-11-21 09:04:54 UTC
I confirm this is resolved now