Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887981 - dev-util/bpftool-6.7.6 adds -Werror flag on its own
Summary: dev-util/bpftool-6.7.6 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jakov Smolić
URL:
Whiteboard:
Keywords: PullRequest
: 920814 (view as bug list)
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2022-12-22 14:54 UTC by Agostino Sarubbo
Modified: 2024-02-24 19:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,107.87 KB, text/plain)
2022-12-22 14:54 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-22 14:54:40 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/bpftool-6.0.12 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-22 14:54:42 UTC
Created attachment 844725 [details]
build.log

build log and emerge --info
Comment 2 Holger Hoffstätte 2023-01-13 11:31:58 UTC
Unfortunately it seems that this is common for all kernel tools, they all have -Werror sprinkled all over the place, often multiple times.
Comment 3 Agostino Sarubbo gentoo-dev 2023-01-25 07:11:33 UTC
ci has reproduced this issue with version 6.1.7 - Updating summary.
Comment 4 Jakov Smolić archtester gentoo-dev 2024-01-06 01:15:03 UTC
*** Bug 920814 has been marked as a duplicate of this bug. ***
Comment 5 Agostino Sarubbo gentoo-dev 2024-02-24 16:44:17 UTC
ci has reproduced this issue with version 6.7.6 - Updating summary.
Comment 6 Holger Hoffstätte 2024-02-24 18:40:30 UTC
This was easier than expected, so I made a PR for 6.6.x and 6.7.x.
Comment 7 Larry the Git Cow gentoo-dev 2024-02-24 19:25:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24220478c1224c5491223df28b8af6d58358d3e8

commit 24220478c1224c5491223df28b8af6d58358d3e8
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2024-02-24 18:22:02 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2024-02-24 19:24:51 +0000

    dev-util/bpftool: remove -Werror
    
    Closes: https://bugs.gentoo.org/887981
    
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 dev-util/bpftool/bpftool-6.6.8.ebuild | 3 +++
 dev-util/bpftool/bpftool-6.7.6.ebuild | 3 +++
 2 files changed, 6 insertions(+)