Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887913 - [guru] sci-electronics/dsview-1.3.0 overwrites user's optimization (-O*)
Summary: [guru] sci-electronics/dsview-1.3.0 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: vowstar
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-22 08:36 UTC by Agostino Sarubbo
Modified: 2024-10-21 09:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,478.94 KB, text/plain)
2022-12-22 08:36 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-22 08:36:11 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-electronics/dsview-1.2.1 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-22 08:36:14 UTC
Created attachment 844687 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-07-19 09:09:20 UTC
guru_ci has reproduced this issue with version 1.3.0 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2024-10-21 09:51:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=015ede5a14fb52ce3c0ec6de6a837d926d757141

commit 015ede5a14fb52ce3c0ec6de6a837d926d757141
Author:     Takuya Wakazono <pastalian46@gmail.com>
AuthorDate: 2024-10-19 09:03:50 +0000
Commit:     Takuya Wakazono <pastalian46@gmail.com>
CommitDate: 2024-10-19 09:03:50 +0000

    sci-electronics/dsview: fix build with GCC 13
    
    Closes: https://bugs.gentoo.org/887877
    Closes: https://bugs.gentoo.org/887913
    Signed-off-by: Takuya Wakazono <pastalian46@gmail.com>

 sci-electronics/dsview/dsview-1.3.0.ebuild         |  9 +++++-
 sci-electronics/dsview/dsview-9999.ebuild          |  7 +++-
 .../dsview/files/dsview-1.3.0-fix-flags.patch      | 14 ++++++++
 .../dsview/files/dsview-1.3.0-gcc13.patch          | 37 ++++++++++++++++++++++
 4 files changed, 65 insertions(+), 2 deletions(-)