Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887905 - [guru] net-p2p/p2pool-2.6-r1 adds -Werror flag on its own
Summary: [guru] net-p2p/p2pool-2.6-r1 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adam
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-22 08:35 UTC by Agostino Sarubbo
Modified: 2022-12-27 08:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,76.08 KB, text/plain)
2022-12-22 08:35 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-22 08:35:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-p2p/p2pool-2.6-r1 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-22 08:35:05 UTC
Created attachment 844679 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2022-12-27 08:05:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=3a7aea9dfccabfca58a173e752ab136e52457b1f

commit 3a7aea9dfccabfca58a173e752ab136e52457b1f
Author:     Adam Pimentel <adam.pimentel@protonmail.com>
AuthorDate: 2022-12-25 21:31:23 +0000
Commit:     Adam Pimentel <adam.pimentel@protonmail.com>
CommitDate: 2022-12-25 21:31:23 +0000

    net-p2p/p2pool: stop build script from overriding users CFLAGS and CXXFLAGS
    
    Closes: https://bugs.gentoo.org/887903
    Closes: https://bugs.gentoo.org/887905
    Signed-off-by: Adam Pimentel <adam.pimentel@protonmail.com>

 net-p2p/p2pool/files/flags.cmake    | 14 ++++++++++++++
 net-p2p/p2pool/p2pool-2.6-r1.ebuild |  5 +++--
 2 files changed, 17 insertions(+), 2 deletions(-)