Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887789 - [guru] media-video/uxplay-1.58 overwrites user's optimization (-O*)
Summary: [guru] media-video/uxplay-1.58 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: vowstar
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-21 20:52 UTC by Agostino Sarubbo
Modified: 2022-12-30 20:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,82.16 KB, text/plain)
2022-12-21 20:52 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 20:52:12 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-video/uxplay-1.58 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 20:52:14 UTC
Created attachment 844585 [details]
build.log

build log and emerge --info
Comment 2 Petrus Zhao 2022-12-28 14:39:21 UTC
See also: https://github.com/FDH2/UxPlay/issues/161
Comment 3 Larry the Git Cow gentoo-dev 2022-12-30 20:36:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=71cce4b60f95af256b177aacd540b60862994652

commit 71cce4b60f95af256b177aacd540b60862994652
Author:     Petrus Zhao <petrus.zy.07@gmail.com>
AuthorDate: 2022-12-30 10:39:02 +0000
Commit:     Petrus Zhao <petrus.zy.07@gmail.com>
CommitDate: 2022-12-30 10:39:43 +0000

    media-video/uxplay: add 1.61, drop 1.60
    
    Closes: https://bugs.gentoo.org/887789
    Closes: https://bugs.gentoo.org/887787
    Signed-off-by: Petrus Zhao <petrus.zy.07@gmail.com>

 media-video/uxplay/Manifest                                   | 2 +-
 media-video/uxplay/{uxplay-1.60.ebuild => uxplay-1.61.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)