Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887775 - [guru] media-libs/amdvlk-2024.3.1 overwrites user's optimization (-O*)
Summary: [guru] media-libs/amdvlk-2024.3.1 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Reva Denis
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru 887773
  Show dependency tree
 
Reported: 2022-12-21 20:46 UTC by Agostino Sarubbo
Modified: 2025-01-13 11:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,596.19 KB, text/plain)
2022-12-21 20:46 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 20:46:24 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/amdvlk-2022.4.4 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 20:46:26 UTC
Created attachment 844571 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-02-23 11:42:36 UTC
guru_ci has reproduced this issue with version 2023.1.1 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2023-03-07 08:14:17 UTC
guru_ci has reproduced this issue with version 2023.1.2 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2024-03-31 20:58:47 UTC
guru_tinderbox has reproduced this issue with version 2023.1.3 - Updating summary.
Comment 5 Agostino Sarubbo gentoo-dev 2024-08-21 21:32:56 UTC
guru_ci has reproduced this issue with version 2024.3.1 - Updating summary.
Comment 6 Alex Barker 2024-10-09 06:12:48 UTC
I am not seeing this issue with 2024.3.1.
Comment 7 Larry the Git Cow gentoo-dev 2025-01-13 11:38:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=cbd773231ecfd53cbbf109475e125de038a98483

commit cbd773231ecfd53cbbf109475e125de038a98483
Author:     Takuya Wakazono <pastalian46@gmail.com>
AuthorDate: 2025-01-12 09:34:04 +0000
Commit:     Takuya Wakazono <pastalian46@gmail.com>
CommitDate: 2025-01-12 09:34:04 +0000

    media-libs/amdvlk: disable forced optimization
    
    Closes: https://bugs.gentoo.org/887775
    Closes: https://bugs.gentoo.org/941510
    Signed-off-by: Takuya Wakazono <pastalian46@gmail.com>

 media-libs/amdvlk/amdvlk-2024.4.3.ebuild | 3 +++
 1 file changed, 3 insertions(+)