Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887671 - [guru] games-engines/fs2_open-23.2.1 overwrites user's optimization (-O*)
Summary: [guru] games-engines/fs2_open-23.2.1 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jonas Frei
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-21 10:17 UTC by Agostino Sarubbo
Modified: 2023-11-16 10:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,47.64 KB, application/x-xz)
2022-12-21 10:17 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 10:17:24 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-engines/fs2_open-22.2.0 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 10:17:26 UTC
Created attachment 844373 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2023-02-14 08:02:00 UTC
guru_ci has reproduced this issue with version 23.0.0 - Updating summary.
Comment 3 Agostino Sarubbo gentoo-dev 2023-10-16 11:40:42 UTC
guru_ci has reproduced this issue with version 23.2.0 - Updating summary.
Comment 4 Agostino Sarubbo gentoo-dev 2023-11-07 07:56:17 UTC
guru_ci has reproduced this issue with version 23.2.1 - Updating summary.
Comment 5 Larry the Git Cow gentoo-dev 2023-11-16 10:05:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=7d9a1b2df949a03883e81d47bda176054480b14a

commit 7d9a1b2df949a03883e81d47bda176054480b14a
Author:     Jonas Frei <freijon@pm.me>
AuthorDate: 2023-11-13 05:33:31 +0000
Commit:     Jonas Frei <freijon@pm.me>
CommitDate: 2023-11-13 05:35:14 +0000

    games-engines/fs2_open: Added patch to respect -O flags, fixes 887671
    
    This new patch is to be removed on the next release, it was implemented
    upstream.
    
    Closes: https://bugs.gentoo.org/887671
    Signed-off-by: Jonas Frei <freijon@pm.me>

 .../fs2_open-23.2.1-dont-ignore-user-cflags.patch  | 117 +++++++++++++++++++++
 ...pen-23.2.1.ebuild => fs2_open-23.2.1-r1.ebuild} |   1 +
 2 files changed, 118 insertions(+)