Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887669 - [guru] games-emulation/dosbox-x-2022.09.1_pre20221210 overwrites user's optimization (-O*)
Summary: [guru] games-emulation/dosbox-x-2022.09.1_pre20221210 overwrites user's optim...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Yuan Liao (Leo3418)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-21 10:17 UTC by Agostino Sarubbo
Modified: 2022-12-27 08:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,48.06 KB, application/x-xz)
2022-12-21 10:17 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 10:17:19 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-emulation/dosbox-x-2022.09.1_pre20221210 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 10:17:22 UTC
Created attachment 844371 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Larry the Git Cow gentoo-dev 2022-12-27 08:05:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=331b5bbba4bfca44785c3ed7d3f367c8e7ef7621

commit 331b5bbba4bfca44785c3ed7d3f367c8e7ef7621
Author:     Yuan Liao <liaoyuan@gmail.com>
AuthorDate: 2022-12-22 00:06:40 +0000
Commit:     Yuan Liao <liaoyuan@gmail.com>
CommitDate: 2022-12-22 00:36:07 +0000

    games-emulation/dosbox-x: Respect user's '-O*' compiler flags
    
    Closes: https://bugs.gentoo.org/887669
    Signed-off-by: Yuan Liao <liaoyuan@gmail.com>

 .../{dosbox-x-2022.08.0.ebuild => dosbox-x-2022.08.0-r1.ebuild}    | 6 ++++++
 ...pre20221210.ebuild => dosbox-x-2022.09.1_pre20221210-r1.ebuild} | 7 +++++++
 games-emulation/dosbox-x/dosbox-x-9999.ebuild                      | 7 +++++++
 3 files changed, 20 insertions(+)