Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887667 - [guru] games-action/blackvoxel-2.50 overwrites user's optimization (-O*)
Summary: [guru] games-action/blackvoxel-2.50 overwrites user's optimization (-O*)
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Samuel Bauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-21 10:17 UTC by Agostino Sarubbo
Modified: 2025-03-03 15:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,195.76 KB, text/plain)
2022-12-21 10:17 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-21 10:17:15 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-action/blackvoxel-2.50 overwrites user's optimization (-O*).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
man gcc says:
"If you use multiple -O options, with or without level numbers, the last such option is the one that is effective".

So, since the build system adds -O* after -O* provided by my CFLAGS/CXXFLAGS means that it is overwritten and unless there are known issues with -O* configured by the user, the build system should not overwrite -O*.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-21 10:17:17 UTC
Created attachment 844369 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2025-03-03 15:10:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2b13b180b08764e6bf5f7c26eca5cd11c2724dbf

commit 2b13b180b08764e6bf5f7c26eca5cd11c2724dbf
Author:     Takuya Wakazono <pastalian46@gmail.com>
AuthorDate: 2025-03-02 14:41:23 +0000
Commit:     Takuya Wakazono <pastalian46@gmail.com>
CommitDate: 2025-03-02 14:58:42 +0000

    games-action/blackvoxel: fix DEPEND and optimization flags
    
    Bug: https://bugs.gentoo.org/932450
    Closes: https://bugs.gentoo.org/887667
    Signed-off-by: Takuya Wakazono <pastalian46@gmail.com>

 games-action/blackvoxel/blackvoxel-2.50.ebuild     | 12 +++---
 games-action/blackvoxel/blackvoxel-9999.ebuild     | 12 +++---
 .../files/blackvoxel-2.50-makefile.patch           | 50 +++++++++++++++++++++-
 3 files changed, 58 insertions(+), 16 deletions(-)