Bug 887649 – [guru] gui-libs/text-engine-0.1.1-r1 fails to compile (CLANG-STRICTER-SYSTEM): layout.c:129:5: error: non-void function text_layout_build_layout_tree should return a value [-Wreturn-type]

• Status: RESOLVED FIXED
• Product: GURU

[Description Agostino Sarubbo 2022-12-21 10:04:35 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-libs/text-engine-0.1.1-r1 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-21 10:04:38 UTC]

Created attachment 844353 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-12-21 10:04:38 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/libtext-engine-0.1.so.p/layout_layout.c.o 
../text-engine-0.1.1/src/layout/layout.c:129:5: error: non-void function 'text_layout_build_layout_tree' should return a value [-Wreturn-type]

[Comment 3 Larry the Git Cow 2022-12-27 08:05:46 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2e65f87613b699434752c4f96cd9e6d2d7075bef

commit 2e65f87613b699434752c4f96cd9e6d2d7075bef
Author:     Yuan Liao <[e-mail]>
AuthorDate: 2022-12-21 20:29:34 +0000
Commit:     Yuan Liao <[e-mail]>
CommitDate: 2022-12-21 20:30:11 +0000

    gui-libs/text-engine: Add patch to fix -Wreturn-type errors
    
    Closes: https://bugs.gentoo.org/887649
    Signed-off-by: Yuan Liao <[e-mail]>

 .../files/text-engine-0.1.1-fix-Wreturn-type.patch | 31 ++++++++++++++++++++++
 ...0.1.1-r1.ebuild => text-engine-0.1.1-r2.ebuild} |  1 +
 2 files changed, 32 insertions(+)