Bug 887641 – [guru] games-action/netrek-brmh-2.6.0 fails to compile (CLANG-STRICTER-SYSTEM): main.c:1060:21: error: incompatible integer to pointer conversion passing int to parameter of type int ; take the address with & [-Wint-conversion]

• Status: RESOLVED FIXED
• Product: GURU

[Description Agostino Sarubbo 2022-12-21 10:02:33 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-action/netrek-brmh-2.6.0 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-21 10:02:35 UTC]

Created attachment 844345 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-12-21 10:02:36 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


defaults.c:177:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:499:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:525:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:541:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:577:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:592:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:609:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:622:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:654:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
defaults.c:714:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
dmessage.c:19:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
dmessage.c:235:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:421:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:462:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:517:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:553:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:613:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:621:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:722:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:759:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:772:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:809:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:823:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:84:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:867:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
entrywin.c:901:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
findslot.c:286:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
findslot.c:332:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
getdefaults.c:597:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
getname.c:194:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
getname.c:310:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
getname.c:347:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
getname.c:49:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
getship.c:167:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
helpwin.c:225:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
inform.c:28:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
input.c:1284:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
input.c:1407:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
input.c:175:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
input.c:51:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
input.c:565:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
input.c:97:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
interface.c:20:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
interface.c:27:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:1250:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:1275:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:1303:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:1408:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:1423:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:438:1: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
main.c:1060:21: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'int *'; take the address with & [-Wint-conversion]

[Comment 3 Larry the Git Cow 2025-03-31 10:07:43 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=c36b3c37759fe8670066dce68d91b9ebd6e79293

commit c36b3c37759fe8670066dce68d91b9ebd6e79293
Author:     Takuya Wakazono <[e-mail]>
AuthorDate: 2025-03-30 06:25:33 +0000
Commit:     Takuya Wakazono <[e-mail]>
CommitDate: 2025-03-30 12:47:09 +0000

    profiles: mask games-action/netrek-brmh for removal
    
    FTBFS bugs open for 2 years.
    
    Bug: https://bugs.gentoo.org/887641
    Bug: https://bugs.gentoo.org/887643
    Bug: https://bugs.gentoo.org/945212
    Signed-off-by: Takuya Wakazono <[e-mail]>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)

[Comment 4 Larry the Git Cow 2025-04-02 07:09:05 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=e9a616b5d3842e686fdb46abec5eeacc4c8adca6

commit e9a616b5d3842e686fdb46abec5eeacc4c8adca6
Author:     brian gloyer <[e-mail]>
AuthorDate: 2025-04-02 05:42:39 +0000
Commit:     brian gloyer <[e-mail]>
CommitDate: 2025-04-02 05:58:52 +0000

    games-action/netrek-brmh: add 2.6.1, drop 2.6.0
    
    Closes: https://bugs.gentoo.org/887641
    Closes: https://bugs.gentoo.org/887643
    Closes: https://bugs.gentoo.org/945212
    Signed-off-by: brian gloyer <[e-mail]>

 games-action/netrek-brmh/Manifest                                    | 2 +-
 .../{netrek-brmh-2.6.0.ebuild => netrek-brmh-2.6.1.ebuild}           | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)