Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887293 - media-libs/vulkan-loader-1.3.236 adds -Werror flag on its own
Summary: media-libs/vulkan-loader-1.3.236 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2022-12-20 07:45 UTC by Agostino Sarubbo
Modified: 2022-12-28 21:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,81.04 KB, text/plain)
2022-12-20 07:45 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-20 07:45:37 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/vulkan-loader-1.3.231 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-20 07:45:39 UTC
Created attachment 843923 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-12-28 21:49:45 UTC
ci has reproduced this issue with version 1.3.236 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2022-12-28 21:53:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7352b7107294f862221540a6e12345150ee6d7d

commit a7352b7107294f862221540a6e12345150ee6d7d
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2022-12-28 21:52:10 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2022-12-28 21:52:54 +0000

    media-libs/vulkan-loader: Don't automatically pass werror
    
    Closes: https://bugs.gentoo.org/887293
    
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 media-libs/vulkan-loader/vulkan-loader-1.3.236.ebuild | 1 +
 media-libs/vulkan-loader/vulkan-loader-9999.ebuild    | 1 +
 2 files changed, 2 insertions(+)