Created attachment 843903 [details] Relevant part of the compile log The linking phase of www-client/firefox-108.0 and www-client/firefox-108.0.1 fails on x86 with the error message error: undefined hidden symbol: tabs_4d51_TabsBridgedEngine_store_incoming On amd64 with a rather analogous setup, the compilation works fine.
Created attachment 843905 [details] emerge --info
Unfortunately I'm away from home so can't test this on x86 for quite some time, and it doesn't look like there's an "easy" fix either. The latest commit in the linked bug, https://hg.mozilla.org/integration/autoland/rev/0c3dbe28af6a -> https://hg.mozilla.org/integration/autoland/raw-rev/0c3dbe28af6a requires you to edit the ebuild with moz_clear_vendor_checksums uniffi moz_clear_vendor_checksums uniffi_bindgen moz_clear_vendor_checksums uniffi_build moz_clear_vendor_checksums uniffi_checksum_derive moz_clear_vendor_checksums uniffi_macros moz_clear_vendor_checksums uniffi_meta in src_prepare(). There's an example with "moz_clear_vendor_checksums bindgen". So need to place the upstream commit as a .patch into /etc/portage/patches and edit the ebuild to try the fix.
yes, I have this error on armv7 too you can pull in patches from debian, the upstream bug is still work in progress it seems this affects all non 64bit, debian had it reported for s390 and x86
uniffi bug report: https://github.com/mozilla/uniffi-rs/pull/1427
You can pull in nicely backported patch, including checksums, from fedora: https://src.fedoraproject.org/rpms/firefox/blob/cd7d2b004aab96ba5a9b1545f1e5244c50f1781a/f/D164896.diff
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e06bb4c99ca4b11528f6aef0935adac2ba636dc0 commit e06bb4c99ca4b11528f6aef0935adac2ba636dc0 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2022-12-30 08:12:41 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-12-30 08:12:41 +0000 profiles/arch/x86: mask >=www-client/firefox-108.0 on x86 Bug: https://bugs.gentoo.org/887277 Signed-off-by: Joonas Niilola <juippis@gentoo.org> profiles/arch/x86/package.mask | 4 ++++ 1 file changed, 4 insertions(+)
Then again, I wonder if building with -clang works for now...? Then I could temporarily package.use.force the choice for these versions instead.
So I added the patch in firefox-108-patches-04j.tar.xz, $ diff -Naur /var/db/repos/gentoo/www-client/firefox/firefox-108.0.1.ebuild ./firefox-108.0.1.ebuild --- /var/db/repos/gentoo/www-client/firefox/firefox-108.0.1.ebuild 2022-12-19 08:22:06.010995118 +0200 +++ ./firefox-108.0.1.ebuild 2023-01-04 15:38:52.858513347 +0200 @@ -3,7 +3,7 @@ EAPI=8 -FIREFOX_PATCHSET="firefox-108-patches-03j.tar.xz" +FIREFOX_PATCHSET="firefox-108-patches-04j.tar.xz" LLVM_MAX_SLOT=15 @@ -646,6 +646,12 @@ # Clearing crate checksums where we have applied patches moz_clear_vendor_checksums bindgen + moz_clear_vendor_checksums uniffi + moz_clear_vendor_checksums uniffi_bindgen + moz_clear_vendor_checksums uniffi_build + moz_clear_vendor_checksums uniffi_checksum_derive + moz_clear_vendor_checksums uniffi_macros + moz_clear_vendor_checksums uniffi_meta # Create build dir BUILD_DIR="${WORKDIR}/${PN}_build" ^ this works in amd64 but on my x86 I'm getting (I guess) unrelated webrtc build issue. This is fixed in upstream for 108.0.2 which should be out ~soon so I'm tempted to wait for that before pursuing further. Although, if someone can confirm that this patch fixes the compilation, I'll push it and remove the x86 related package.mask.
firefox-108.0.2 is released, the fix for this bug was backported will check for webrtc breakage you reported, once ebuild is in tree
I managed to build firefox-108.0.2 on x86, will finish all tests on amd64 before pushing. I'll unmask 108.0.2 on x86 when pushing the new version. Simple copypaste from 108.0.1 worked, no need to update patch sets.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61c208fe646cb9f26b25ae54d35f3e6d0114f056 commit 61c208fe646cb9f26b25ae54d35f3e6d0114f056 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-01-05 09:11:18 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-01-05 09:23:27 +0000 www-client/firefox: add 108.0.2 Closes: https://bugs.gentoo.org/887277 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 98 +++ www-client/firefox/firefox-108.0.2.ebuild | 1330 +++++++++++++++++++++++++++++ 2 files changed, 1428 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9b4972530148dd2e36103d7b07c45eb8d77f7db commit d9b4972530148dd2e36103d7b07c45eb8d77f7db Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-01-05 09:16:36 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-01-05 09:23:28 +0000 profiles/arch/x86: unmask firefox >=108 - 108.0.2 is available with an upstream fix to bug #887277. Bug: https://bugs.gentoo.org/887277 Signed-off-by: Joonas Niilola <juippis@gentoo.org> profiles/arch/x86/package.mask | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
