Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887253 - profiles: unset GDK_PIXBUF_MODULE_FILE environment variable (Patch)
Summary: profiles: unset GDK_PIXBUF_MODULE_FILE environment variable (Patch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://github.com/trofi/nix-guix-gen...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2022-12-19 18:54 UTC by Sergei Trofimovich
Modified: 2023-01-05 00:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-profiles-unset-GDK_PIXBUF_MODULE_FILE (0001-profiles-unset-GDK_PIXBUF_MODULE_FILE.patch.txt,2.58 KB, patch)
2022-12-19 18:56 UTC, Sergei Trofimovich
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich 2022-12-19 18:54:37 UTC
It's a forward of https://github.com/trofi/nix-guix-gentoo/issues/25 where Gooberpatrol66 experienced x11-themes/adwaita-icon-theme-43_p1 build failure when `GDK_PIXBUF_MODULE_FILE` environment variable is set to point outside `::gentoo`'s `librsvg` library.

Reproducible: Always




`GDK_PIXBUF_MODULE_FILE` is one of variables used to redirect `librsvg`
plugins. Avoid clobber if that variables set by `guix environment` and
other redirectors like in https://github.com/trofi/nix-guix-gentoo/issues/25

Otherwise in environments that already set `GDK_PIXBUF_MODULE_FILE`
(examples are `guix shell`, `guix environment` and shell wrappers
around gtk programs using librsvg from non-standard location)
building packages with `emrge` fail as:

    # set by guix automatically
    $ export GDK_PIXBUF_MODULE_FILE="/home/.../.guix-profile/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache"

    $ sudo emerge -1 x11-themes/adwaita-icon-theme-43_p1:0
    ...
    /usr/sbin/gtk-encode-symbolic-svg: symbol lookup error:
      /gnu/store/...-glibc-2.33/lib/libpthread.so.0:
        undefined symbol: __libc_pthread_init, version GLIBC_PRIVATE

The change adds `GDK_PIXBUF_MODULE_FILE` to the list of variables
cleaned by `emerge`. I assume the `::gentoo` does not rely on external
librsvg loaders anyway.
Comment 1 Sergei Trofimovich 2022-12-19 18:56:00 UTC
Created attachment 843875 [details, diff]
0001-profiles-unset-GDK_PIXBUF_MODULE_FILE

0001-profiles-unset-GDK_PIXBUF_MODULE_FILE is an example patch to avoid injection of incompatible loader.
Comment 2 Mike Gilbert gentoo-dev 2022-12-22 19:08:13 UTC
Giving this to the gnome team.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-02 00:31:58 UTC
Profile changes need to go to the mailing list if unsure, so I'll send it there.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-02 00:33:38 UTC
(In reply to Sam James from comment #3)
> Profile changes need to go to the mailing list if unsure, so I'll send it
> there.

s/if unsure/make.defaults/ (https://devmanual.gentoo.org/profiles/make.defaults/index.html).

Sent, thanks!
Comment 5 Larry the Git Cow gentoo-dev 2023-01-05 00:33:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07202f3ff2e3278c8998130f296b1b0f3e3dda98

commit 07202f3ff2e3278c8998130f296b1b0f3e3dda98
Author:     Sergei Trofimovich <slyich@gmail.com>
AuthorDate: 2022-12-11 13:19:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-05 00:31:01 +0000

    profiles: unset GDK_PIXBUF_MODULE_FILE
    
    `GDK_PIXBUF_MODULE_FILE` is one of variables used to redirect `librsvg`
    plugins. Avoid clobber if that variables set by `guix environment` and
    other redirectors like in https://github.com/trofi/nix-guix-gentoo/issues/25
    
    Closes: https://bugs.gentoo.org/887253
    Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/base/make.defaults     | 2 +-
 profiles/embedded/make.defaults | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)