Bug 886597 – sci-mathematics/prover9-2009.11a-r1 fails to compile (CLANG-STRICTER-SYSTEM): select.c:236:44: error: parameter max_constrained was not declared, defaults to int; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-12-18 10:10:40 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-mathematics/prover9-2009.11a fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-18 10:10:42 UTC]

Created attachment 843351 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2024-08-04 17:56:36 UTC]

tinderbox_musl has reproduced this issue with version 2009.11a-r1 - Updating summary.

[Comment 3 Larry the Git Cow 2025-02-23 22:23:20 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d739c66f105c508c0eff3ac4d8d287debc86ae0

commit 4d739c66f105c508c0eff3ac4d8d287debc86ae0
Author:     NHOrus <[e-mail]>
AuthorDate: 2025-02-23 19:34:55 +0000
Commit:     Maciej Barć <[e-mail]>
CommitDate: 2025-02-23 22:23:16 +0000

    sci-mathematics/prover9: Port to C99, fix parallel build.
    
    Add ints to implicitly-declared function parameters that are actually ints
    Remove all the cleans that were scattered around makefiles. They are useful
    for development only and only hinder packaged build.
    Pipe CFLAG to last place it's needed to be used, for linking a library.
    
    Closes: https://bugs.gentoo.org/728030
    Closes: https://bugs.gentoo.org/871261
    Closes: https://bugs.gentoo.org/881475
    Closes: https://bugs.gentoo.org/886597
    Closes: https://bugs.gentoo.org/887409
    Closes: https://bugs.gentoo.org/911554
    Signed-off-by: NHOrus <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/40720
    Signed-off-by: Maciej Barć <[e-mail]>

 .../prover9/files/LADR-2009-11A-c99.patch          | 25 ++++++
 .../files/LADR-2009-11A-stable-ordering.patch      | 91 ++++++++++++++++++++++
 ...09.11a-r1.ebuild => prover9-2009.11a-r2.ebuild} |  9 ++-
 3 files changed, 121 insertions(+), 4 deletions(-)