Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 886593 - sci-libs/volk-2.5.1 installs less files with clang stricter
Summary: sci-libs/volk-2.5.1 installs less files with clang stricter
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2022-12-18 10:05 UTC by Agostino Sarubbo
Modified: 2023-08-03 18:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-18 10:05:55 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/volk-2.5.1 installs less files with clang stricter.
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
To reproduce this issue:
1) Install the package with CC=clang - CXX=clang++
2) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist1 )
3) Install the package with CC=clang - CXX=clang++ - CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types
4) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist2 )
5) See the diff between the two files ( diff -ru /tmp/qlist_1 /tmp/qlist_2 )

On this machine:
- the installed files with clang are 189
- the installed files with clang stricter are 180

This type of report comes from a check that is a bit outside of the tinderbox, that's the reason because build.log was not provided (however in cases like these the build.log doesn't help much) but if you need further help to diagnose this issue feel free to ask.

In any case I'm providing a diff.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-18 10:06:22 UTC
DIFF:
--- /dev/fd/63  2022-12-17 09:45:06.503040633 +0100
+++ /dev/fd/62  2022-12-17 09:45:06.503040633 +0100
@@ -1,10 +1,6 @@
-/usr/bin/list_cpu_features
 /usr/bin/volk-config-info
 /usr/bin/volk_modtool
 /usr/bin/volk_profile
-/usr/include/cpu_features/cpu_features_cache_info.h
-/usr/include/cpu_features/cpu_features_macros.h
-/usr/include/cpu_features/cpuinfo_x86.h
 /usr/include/volk/constants.h
 /usr/include/volk/saturation_arithmetic.h
 /usr/include/volk/volk.h
@@ -173,15 +169,10 @@
 /usr/lib/python3.10/site-packages/volk_modtool/__pycache__/volk_modtool_generate.cpython-310.pyc
 /usr/lib/python3.10/site-packages/volk_modtool/cfg.py
 /usr/lib/python3.10/site-packages/volk_modtool/volk_modtool_generate.py
-/usr/lib64/cmake/CpuFeatures/CpuFeaturesConfig.cmake
-/usr/lib64/cmake/CpuFeatures/CpuFeaturesConfigVersion.cmake
-/usr/lib64/cmake/CpuFeatures/CpuFeaturesTargets-none.cmake
-/usr/lib64/cmake/CpuFeatures/CpuFeaturesTargets.cmake
 /usr/lib64/cmake/volk/VolkConfig.cmake
 /usr/lib64/cmake/volk/VolkConfigVersion.cmake
 /usr/lib64/cmake/volk/VolkTargets-none.cmake
 /usr/lib64/cmake/volk/VolkTargets.cmake
-/usr/lib64/libcpu_features.a
 /usr/lib64/libvolk.so
 /usr/lib64/libvolk.so.2.5
 /usr/lib64/libvolk.so.2.5.1
Comment 2 Rick Farina (Zero_Chaos) gentoo-dev 2023-08-03 18:51:39 UTC
This bug actually turns out to be completely unrelated to clang stricter, but thanks for the report.  I have reported this upstream and pushed a short term fix to gentoo.

https://github.com/gnuradio/volk/issues/626
Comment 3 Larry the Git Cow gentoo-dev 2023-08-03 18:57:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e357a38f91c29a5730232ff07cef4b0728dffd97

commit e357a38f91c29a5730232ff07cef4b0728dffd97
Author:     Rick Farina <zerochaos@gentoo.org>
AuthorDate: 2023-08-03 18:56:38 +0000
Commit:     Rick Farina <zerochaos@gentoo.org>
CommitDate: 2023-08-03 18:57:57 +0000

    sci-libs/volk: fix incorrect circular deps
    
    Also allow FEATURES="test" and don't install files which are only needed
    for testing.
    Signed-off-by: Rick Farina <zerochaos@gentoo.org>
    Fixes: https://bugs.gentoo.org/886593

 .../volk/{volk-3.0.0.ebuild => volk-3.0.0-r1.ebuild}     | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)