Bug 886465 – sci-libs/stellarsolver-2.5 fails to compile: bl-sort.c:68:9: error: call to undeclared function qsort_r; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-12-17 08:55:32 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/stellarsolver-2.4 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-12-17 08:55:34 UTC]

Created attachment 843194 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-12-17 08:55:36 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: CMakeFiles/stellarsolver.dir/stellarsolver/astrometry/util/bl-sort.c.o 
FAILED: CMakeFiles/stellarsolver.dir/stellarsolver/astrometry/util/permutedsort.c.o 
/var/tmp/portage/sci-libs/stellarsolver-2.4/work/stellarsolver-2.4/stellarsolver/astrometry/util/bl-sort.c:68:9: error: call to undeclared function 'qsort_r'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]

[Comment 3 Agostino Sarubbo 2024-01-30 14:20:31 UTC]

gcc14_tinderbox has reproduced this issue with version 2.5 - Updating summary.

[Comment 4 Larry the Git Cow 2024-03-17 08:42:35 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=681f94760646bda2d7089ed485a6dbe985b97def

commit 681f94760646bda2d7089ed485a6dbe985b97def
Author:     Sam James <[e-mail]>
AuthorDate: 2024-03-17 08:40:04 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-17 08:42:04 +0000

    sci-libs/stellarsolver: filter LTO
    
    I haven't reported this upstream because I can't even build it with GCC 14
    (bug #886465).
    
    Bug: https://bugs.gentoo.org/886465
    Closes: https://bugs.gentoo.org/862930
    Signed-off-by: Sam James <[e-mail]>

 sci-libs/stellarsolver/stellarsolver-2.5.ebuild | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

[Comment 5 Larry the Git Cow 2024-04-22 17:52:14 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65f38f29b1d319f64a4c37d3c55ce487d654049a

commit 65f38f29b1d319f64a4c37d3c55ce487d654049a
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2024-04-22 17:46:04 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2024-04-22 17:51:45 +0000

    sci-libs/stellarsolver: Fix QA warnings
    
    Closes: https://bugs.gentoo.org/873595
    Closes: https://bugs.gentoo.org/886465
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 .../files/stellarsolver-2.5-compiler-warning.patch |  26 ++
 .../files/stellarsolver-2.5-qsort-warning.patch    | 291 +++++++++++++++++++++
 sci-libs/stellarsolver/stellarsolver-2.5-r1.ebuild |  37 +++
 3 files changed, 354 insertions(+)