Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885991 - x11-libs/libwnck-43.0 breaks Xfce X2Go sessions
Summary: x11-libs/libwnck-43.0 breaks Xfce X2Go sessions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on: 888493
Blocks:
  Show dependency tree
 
Reported: 2022-12-14 20:15 UTC by foufou33
Modified: 2023-01-13 16:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description foufou33 2022-12-14 20:15:50 UTC
Reported on manjaro [1]. reading through the comments there it seams that 
Upstream seems to be aware of it [2]: 
as suggested in the comments section of the upstream bug report, reverting https://gitlab.gnome.org/GNOME/libwnck/-/commit/07694559cc0c65ce1cca9ac33b165cef84c34d5e solves it 

[1] https://forum.manjaro.org/t/xfce4-panel-crashing/124194
[2] https://gitlab.gnome.org/GNOME/libwnck/-/issues/154


Reproducible: Always

Steps to Reproduce:
1.setup x2go
2.start remote session using xfce4
3.
Actual Results:  
xfce crashes (resulting a in black screen)


Expected Results:  
an xfce4 session 

error log is filled with :
The error was 'BadRequest (invalid request code or no such operation)'.
  (Details: serial 151 error_code 1 request_code 148 (X-Resource) minor_code 4)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
Comment 1 foufou33 2022-12-15 00:35:28 UTC
Upon further reading, what seems the the proper  fix has been merged :

https://gitlab.gnome.org/GNOME/libwnck/-/merge_requests/47/diffs
Comment 2 Joseph 2022-12-17 22:02:39 UTC
I've noticed the same thing.

When I set in x2go "XFCE" I deg a grey screen and in the log I see x2go in the server is trying to select KDE, there is what I see in session log:

...
Loop: WARNING! Unrecognized session type 'unix-kde-depth_24'. Assuming agent session.
Warning: Unrecognized session type 'unix-kde-depth_24'. Assuming agent session.
... 

So the only version available in portage is: 
x11-libs/libwnck-43.0

or: x11-libs/libwnck-2.31.0-r1

is it safe to downgrade to?: x11-libs/libwnck-2.31.0-r1
Comment 3 foufou33 2022-12-17 22:18:34 UTC
(In reply to Joseph from comment #2)
> I've noticed the same thing.
> 
> When I set in x2go "XFCE" I deg a grey screen and in the log I see x2go in
> the server is trying to select KDE, there is what I see in session log:
> 
> ...
> Loop: WARNING! Unrecognized session type 'unix-kde-depth_24'. Assuming agent
> session.
> Warning: Unrecognized session type 'unix-kde-depth_24'. Assuming agent
> session.
> ... 
> 
> So the only version available in portage is: 
> x11-libs/libwnck-43.0
> 
> or: x11-libs/libwnck-2.31.0-r1
> 
> is it safe to downgrade to?: x11-libs/libwnck-2.31.0-r1

put https://gitlab.gnome.org/GNOME/libwnck/-/merge_requests/47/diffs.patch 
in /etc/portage/patches/x11-libs/libwnck-43.0/ the4n rebuild libwnck.
it should solve the issue.


disable compositor, otherwise you'll get an ugly black outline where shadows are supposed to be.
Comment 4 Joseph 2022-12-17 22:39:36 UTC
(In reply to foufou33 from comment #3)
> (In reply to Joseph from comment #2)

[snip]

> 
> put https://gitlab.gnome.org/GNOME/libwnck/-/merge_requests/47/diffs.patch 
> in /etc/portage/patches/x11-libs/libwnck-43.0/ the4n rebuild libwnck.
> it should solve the issue.
> 
> 
> disable compositor, otherwise you'll get an ugly black outline where shadows
> are supposed to be.

I've never patch anything, need a bit of help.
So, same the content of https://gitlab.gnome.org/GNOME/libwnck/-/merge_requests/47/diffs.patch 
as "diffs.patch"

create directory: 
/etc/portage/patches/x11-libs/libwnck-43.0/

and emerge x11-libs/libwnck-43.0 

How to disable "compositor"?  I assume it is some kind of setting in XFCE.
Disable it on a computer I'm connecting to or the one I'm connecting from?
Comment 5 Joseph 2022-12-17 23:38:10 UTC
Thank you foufou33, your solution worked.
Comment 6 Larry the Git Cow gentoo-dev 2022-12-19 09:41:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34e96310a207cf1a6d4d5f8a0d2e25aa5ec920fd

commit 34e96310a207cf1a6d4d5f8a0d2e25aa5ec920fd
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2022-12-19 09:30:20 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2022-12-19 09:30:20 +0000

    x11-libs/libwnck: Fix crashes on xfce and segfault
    
    Applying upstream fixes that will be included in the next release
    
    Bug: https://bugs.gentoo.org/885991
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 ...libwnck-43.0-segfault_in_invalidate_icons.patch |  29 ++
 .../files/libwnck-43.0-xres-extension.patch        | 380 +++++++++++++++++++++
 x11-libs/libwnck/libwnck-43.0-r1.ebuild            |  60 ++++
 3 files changed, 469 insertions(+)
Comment 7 Joseph 2022-12-19 23:52:19 UTC
(In reply to Larry the Git Cow from comment #6)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=34e96310a207cf1a6d4d5f8a0d2e25aa5ec920fd
> 
> commit 34e96310a207cf1a6d4d5f8a0d2e25aa5ec920fd
> Author:     Pacho Ramos <pacho@gentoo.org>
> AuthorDate: 2022-12-19 09:30:20 +0000
> Commit:     Pacho Ramos <pacho@gentoo.org>
> CommitDate: 2022-12-19 09:30:20 +0000
> 
>     x11-libs/libwnck: Fix crashes on xfce and segfault
>     
>     Applying upstream fixes that will be included in the next release
>     
>     Bug: https://bugs.gentoo.org/885991
>     Signed-off-by: Pacho Ramos <pacho@gentoo.org>
> 
>  ...libwnck-43.0-segfault_in_invalidate_icons.patch |  29 ++
>  .../files/libwnck-43.0-xres-extension.patch        | 380
> +++++++++++++++++++++
>  x11-libs/libwnck/libwnck-43.0-r1.ebuild            |  60 ++++
>  3 files changed, 469 insertions(+)

I just try to emerge: x11-libs/libwnck/libwnck-43.0-r1 but I'm getting an error message:


[ebuild  rR   ] virtual/perl-ExtUtils-MakeMaker-7.640.0 
[ebuild     U ] x11-libs/libwnck-43.0-r1 [43.0] USE="introspection startup-notification -gtk-doc -tools" 

!!! The following installed packages are masked:
- net-mail/metamail-2.7.53.3-r3::gentoo (masked by: package.mask)
/var/db/repos/gentoo/profiles/package.mask:
# Pascal Jäger <pascal.jaeger@leimstift.de> (2022-11-24)
# No maintainer, last release in 1994. Fails to build
# with clang-16. Runtime crash in certain conditions.
# Removal on 2022-12-23.
# Bugs #549922 #713492 #731256 #875464 #882263
# Removal Bug: #882631

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.


Would you like to merge these packages? [Yes/No] y
>>> Verifying ebuild manifests
>>> Emerging (1 of 2) virtual/perl-ExtUtils-MakeMaker-7.640.0::gentoo
>>> Installing (1 of 2) virtual/perl-ExtUtils-MakeMaker-7.640.0::gentoo
>>> Emerging (2 of 2) x11-libs/libwnck-43.0-r1::gentoo
>>> Failed to emerge x11-libs/libwnck-43.0-r1, Log file:
>>>  '/var/tmp/portage/x11-libs/libwnck-43.0-r1/temp/build.log'
>>> Jobs: 1 of 2 complete, 1 failed                 Load avg: 1.07, 3.15, 4.90
 * Package:    x11-libs/libwnck-43.0-r1:3
 * Repository: gentoo
 * Maintainer: gnome@gentoo.org
 * USE:        abi_x86_64 amd64 elibc_glibc introspection kernel_linux startup-notification userland_GNU
 * FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox
 * Applying libwnck-43.0-xres-extension.patch ...
patching file libwnck/wnck-handle-private.h
patching file libwnck/wnck-handle.c
patching file meson.build
patching file libwnck/xutils.c
patching file libwnck/application.c
patching file libwnck/window.c
patching file libwnck/wnck-resource-usage.c
patching file libwnck/xutils.c
patching file libwnck/xutils.h
patching file libwnck/xutils.c
 [ ok ]
 * Applying libwnck-43.0-segfault_in_invalidate_icons.patch ...
 [ ok ]
 * ====================================================================================================================================
 * Applying user patches from /etc/portage/patches ...
 * Applying diffs.patch ...
patching file libwnck/wnck-handle-private.h
Hunk #1 succeeded at 28 with fuzz 2 (offset 2 lines).
patching file libwnck/wnck-handle.c
Hunk #1 succeeded at 34 with fuzz 2 (offset 5 lines).
Hunk #2 succeeded at 55 with fuzz 2 (offset 7 lines).
Hunk #3 succeeded at 215 with fuzz 1 (offset 44 lines).
Hunk #4 FAILED at 331.
Hunk #5 succeeded at 435 with fuzz 1 (offset 51 lines).
1 out of 5 hunks FAILED -- saving rejects to file libwnck/wnck-handle.c.rej
patching file meson.build
Hunk #1 FAILED at 45.
1 out of 1 hunk FAILED -- saving rejects to file meson.build.rej
patching file libwnck/xutils.c
Hunk #1 FAILED at 1145.
Hunk #2 FAILED at 1172.
2 out of 2 hunks FAILED -- saving rejects to file libwnck/xutils.c.rej
patching file libwnck/application.c
Hunk #1 FAILED at 524.
1 out of 1 hunk FAILED -- saving rejects to file libwnck/application.c.rej
patching file libwnck/window.c
Hunk #1 FAILED at 510.
1 out of 1 hunk FAILED -- saving rejects to file libwnck/window.c.rej
patching file libwnck/wnck-resource-usage.c
Hunk #1 FAILED at 126.
Hunk #2 FAILED at 138.
Hunk #3 FAILED at 250.
3 out of 3 hunks FAILED -- saving rejects to file libwnck/wnck-resource-usage.c.rej
patching file libwnck/xutils.c
Hunk #1 FAILED at 1147.
Hunk #2 FAILED at 1178.
Hunk #3 FAILED at 1190.
3 out of 3 hunks FAILED -- saving rejects to file libwnck/xutils.c.rej
patching file libwnck/xutils.h
Hunk #1 FAILED at 123.
1 out of 1 hunk FAILED -- saving rejects to file libwnck/xutils.h.rej
patching file libwnck/xutils.c
Hunk #1 succeeded at 1159 with fuzz 2 (offset 3 lines).
 [ !! ]
 * ERROR: x11-libs/libwnck-43.0-r1::gentoo failed (prepare phase):
 *   patch -p1  failed with /etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch
 * 
 * Call stack:
 *               ebuild.sh, line  136:  Called src_prepare
 *             environment, line 2284:  Called default
 *      phase-functions.sh, line  872:  Called default_src_prepare
 *      phase-functions.sh, line  948:  Called __eapi8_src_prepare
 *             environment, line  364:  Called eapply_user
 *             environment, line 1112:  Called eapply '/etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch'
 *             environment, line 1075:  Called _eapply_patch '/etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch'
 *             environment, line 1013:  Called __helpers_die 'patch -p1  failed with /etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch'
 *   isolated-functions.sh, line  112:  Called die
 * The specific snippet of code:
 *   		die "$@"
 * 
 * If you need support, post the output of `emerge --info '=x11-libs/libwnck-43.0-r1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=x11-libs/libwnck-43.0-r1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/x11-libs/libwnck-43.0-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-libs/libwnck-43.0-r1/temp/environment'.
 * Working directory: '/var/tmp/portage/x11-libs/libwnck-43.0-r1/work/libwnck-43.0'
 * S: '/var/tmp/portage/x11-libs/libwnck-43.0-r1/work/libwnck-43.0'
Comment 8 foufou33 2022-12-20 01:45:44 UTC
(In reply to Joseph from comment #7)
> (In reply to Larry the Git Cow from comment #6)
> > The bug has been referenced in the following commit(s):
> > 
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/
> > ?id=34e96310a207cf1a6d4d5f8a0d2e25aa5ec920fd
> > 
> > commit 34e96310a207cf1a6d4d5f8a0d2e25aa5ec920fd
> > Author:     Pacho Ramos <pacho@gentoo.org>
> > AuthorDate: 2022-12-19 09:30:20 +0000
> > Commit:     Pacho Ramos <pacho@gentoo.org>
> > CommitDate: 2022-12-19 09:30:20 +0000
> > 
> >     x11-libs/libwnck: Fix crashes on xfce and segfault
> >     
> >     Applying upstream fixes that will be included in the next release
> >     
> >     Bug: https://bugs.gentoo.org/885991
> >     Signed-off-by: Pacho Ramos <pacho@gentoo.org>
> > 
> >  ...libwnck-43.0-segfault_in_invalidate_icons.patch |  29 ++
> >  .../files/libwnck-43.0-xres-extension.patch        | 380
> > +++++++++++++++++++++
> >  x11-libs/libwnck/libwnck-43.0-r1.ebuild            |  60 ++++
> >  3 files changed, 469 insertions(+)
> 
> I just try to emerge: x11-libs/libwnck/libwnck-43.0-r1 but I'm getting an
> error message:
> 
> 
> [ebuild  rR   ] virtual/perl-ExtUtils-MakeMaker-7.640.0 
> [ebuild     U ] x11-libs/libwnck-43.0-r1 [43.0] USE="introspection
> startup-notification -gtk-doc -tools" 
> 
> !!! The following installed packages are masked:
> - net-mail/metamail-2.7.53.3-r3::gentoo (masked by: package.mask)
> /var/db/repos/gentoo/profiles/package.mask:
> # Pascal Jäger <pascal.jaeger@leimstift.de> (2022-11-24)
> # No maintainer, last release in 1994. Fails to build
> # with clang-16. Runtime crash in certain conditions.
> # Removal on 2022-12-23.
> # Bugs #549922 #713492 #731256 #875464 #882263
> # Removal Bug: #882631
> 
> For more information, see the MASKED PACKAGES section in the emerge
> man page or refer to the Gentoo Handbook.
> 
> 
> Would you like to merge these packages? [Yes/No] y
> >>> Verifying ebuild manifests
> >>> Emerging (1 of 2) virtual/perl-ExtUtils-MakeMaker-7.640.0::gentoo
> >>> Installing (1 of 2) virtual/perl-ExtUtils-MakeMaker-7.640.0::gentoo
> >>> Emerging (2 of 2) x11-libs/libwnck-43.0-r1::gentoo
> >>> Failed to emerge x11-libs/libwnck-43.0-r1, Log file:
> >>>  '/var/tmp/portage/x11-libs/libwnck-43.0-r1/temp/build.log'
> >>> Jobs: 1 of 2 complete, 1 failed                 Load avg: 1.07, 3.15, 4.90
>  * Package:    x11-libs/libwnck-43.0-r1:3
>  * Repository: gentoo
>  * Maintainer: gnome@gentoo.org
>  * USE:        abi_x86_64 amd64 elibc_glibc introspection kernel_linux
> startup-notification userland_GNU
>  * FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox
>  * Applying libwnck-43.0-xres-extension.patch ...
> patching file libwnck/wnck-handle-private.h
> patching file libwnck/wnck-handle.c
> patching file meson.build
> patching file libwnck/xutils.c
> patching file libwnck/application.c
> patching file libwnck/window.c
> patching file libwnck/wnck-resource-usage.c
> patching file libwnck/xutils.c
> patching file libwnck/xutils.h
> patching file libwnck/xutils.c
>  [ ok ]
>  * Applying libwnck-43.0-segfault_in_invalidate_icons.patch ...
>  [ ok ]
>  *
> =============================================================================
> =======================================================
>  * Applying user patches from /etc/portage/patches ...
>  * Applying diffs.patch ...
> patching file libwnck/wnck-handle-private.h
> Hunk #1 succeeded at 28 with fuzz 2 (offset 2 lines).
> patching file libwnck/wnck-handle.c
> Hunk #1 succeeded at 34 with fuzz 2 (offset 5 lines).
> Hunk #2 succeeded at 55 with fuzz 2 (offset 7 lines).
> Hunk #3 succeeded at 215 with fuzz 1 (offset 44 lines).
> Hunk #4 FAILED at 331.
> Hunk #5 succeeded at 435 with fuzz 1 (offset 51 lines).
> 1 out of 5 hunks FAILED -- saving rejects to file libwnck/wnck-handle.c.rej
> patching file meson.build
> Hunk #1 FAILED at 45.
> 1 out of 1 hunk FAILED -- saving rejects to file meson.build.rej
> patching file libwnck/xutils.c
> Hunk #1 FAILED at 1145.
> Hunk #2 FAILED at 1172.
> 2 out of 2 hunks FAILED -- saving rejects to file libwnck/xutils.c.rej
> patching file libwnck/application.c
> Hunk #1 FAILED at 524.
> 1 out of 1 hunk FAILED -- saving rejects to file libwnck/application.c.rej
> patching file libwnck/window.c
> Hunk #1 FAILED at 510.
> 1 out of 1 hunk FAILED -- saving rejects to file libwnck/window.c.rej
> patching file libwnck/wnck-resource-usage.c
> Hunk #1 FAILED at 126.
> Hunk #2 FAILED at 138.
> Hunk #3 FAILED at 250.
> 3 out of 3 hunks FAILED -- saving rejects to file
> libwnck/wnck-resource-usage.c.rej
> patching file libwnck/xutils.c
> Hunk #1 FAILED at 1147.
> Hunk #2 FAILED at 1178.
> Hunk #3 FAILED at 1190.
> 3 out of 3 hunks FAILED -- saving rejects to file libwnck/xutils.c.rej
> patching file libwnck/xutils.h
> Hunk #1 FAILED at 123.
> 1 out of 1 hunk FAILED -- saving rejects to file libwnck/xutils.h.rej
> patching file libwnck/xutils.c
> Hunk #1 succeeded at 1159 with fuzz 2 (offset 3 lines).
>  [ !! ]
>  * ERROR: x11-libs/libwnck-43.0-r1::gentoo failed (prepare phase):
>  *   patch -p1  failed with
> /etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch
>  * 
>  * Call stack:
>  *               ebuild.sh, line  136:  Called src_prepare
>  *             environment, line 2284:  Called default
>  *      phase-functions.sh, line  872:  Called default_src_prepare
>  *      phase-functions.sh, line  948:  Called __eapi8_src_prepare
>  *             environment, line  364:  Called eapply_user
>  *             environment, line 1112:  Called eapply
> '/etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch'
>  *             environment, line 1075:  Called _eapply_patch
> '/etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch'
>  *             environment, line 1013:  Called __helpers_die 'patch -p1 
> failed with /etc/portage/patches/x11-libs/libwnck-43.0/diffs.patch'
>  *   isolated-functions.sh, line  112:  Called die
>  * The specific snippet of code:
>  *   		die "$@"
>  * 
>  * If you need support, post the output of `emerge --info
> '=x11-libs/libwnck-43.0-r1::gentoo'`,
>  * the complete build log and the output of `emerge -pqv
> '=x11-libs/libwnck-43.0-r1::gentoo'`.
>  * The complete build log is located at
> '/var/tmp/portage/x11-libs/libwnck-43.0-r1/temp/build.log'.
>  * The ebuild environment file is located at
> '/var/tmp/portage/x11-libs/libwnck-43.0-r1/temp/environment'.
>  * Working directory:
> '/var/tmp/portage/x11-libs/libwnck-43.0-r1/work/libwnck-43.0'
>  * S: '/var/tmp/portage/x11-libs/libwnck-43.0-r1/work/libwnck-43.0'

remove the file you previously downloaded (or better yet the whole directory if there's nothing else there : /etc/portage/patches/x11-libs/libwnck-43.0/)
Comment 9 Joseph 2022-12-20 21:44:52 UTC
(In reply to foufou33 from comment #8)
> (In reply to Joseph from comment #7)

[snip]

> 
> remove the file you previously downloaded (or better yet the whole directory
> if there's nothing else there : /etc/portage/patches/x11-libs/libwnck-43.0/)

Yes, that worked!
Thank you.