Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885741 - app-admin/pass-otp-1.2.0-r1 fails tests (DASH-SYSTEM)
Summary: app-admin/pass-otp-1.2.0-r1 fails tests (DASH-SYSTEM)
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Haelwenn (lanodan) Monnier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: nonbash
  Show dependency tree
 
Reported: 2022-12-13 09:36 UTC by Agostino Sarubbo
Modified: 2024-04-03 02:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,49.46 KB, text/plain)
2022-12-13 09:36 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-13 09:36:15 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/pass-otp-1.2.0-r1 fails tests (DASH-SYSTEM).
Discovered on: amd64 (internal ref: dash_tinderbox)
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-13 09:36:17 UTC 
Created attachment 842373 [details]
build.log

build log and emerge --info
Comment 2 ktoupt 2024-04-03 02:56:48 UTC 
I could be wrong, but I do not think this is a dash specific issue.

Here is an upstream bug from a Fedora user, which, I think, does not use
dash:

https://github.com/tadfisher/pass-otp/issues/171

The issue is with incrementing the HOTP counter in the otp.bash script.
Instead of replacing the old counter text, it appends the new text after
the old text.

It seems that the issue is missing quotes around a shell parameter
expansion, as seen from this patch:

https://github.com/tadfisher/pass-otp/pull/172