Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885709 - net-dialup/minicom-2.8-r1 installs less files on second emerge (weird /etc/minicom/minirc.dfl logic)
Summary: net-dialup/minicom-2.8-r1 installs less files on second emerge (weird /etc/mi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-12-13 03:56 UTC by Agostino Sarubbo
Modified: 2023-03-19 06:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-13 03:56:28 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-dialup/minicom-2.8-r1 installs less files with clang stricter.
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
To reproduce this issue:
1) Install the package with CC=clang - CXX=clang++
2) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist1 )
3) Install the package with CC=clang - CXX=clang++ - CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types
4) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist2 )
5) See the diff between the two files ( diff -ru /tmp/qlist_1 /tmp/qlist_2 )

On this machine:
- the installed files with clang are 34
- the installed files with clang stricter are 33

This type of report comes from a check that is a bit outside of the tinderbox, that's the reason because build.log was not provided (however in cases like these the build.log doesn't help much) but if you need further help to diagnose this issue feel free to ask.

In any case I'm providing a diff.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-13 03:56:49 UTC
DIFF:
--- /dev/fd/63  2022-12-13 00:30:06.516583254 +0100
+++ /dev/fd/62  2022-12-13 00:30:06.516583254 +0100
@@ -1,4 +1,3 @@
-/etc/minicom/minirc.dfl
 /usr/bin/ascii-xfr
 /usr/bin/minicom
 /usr/bin/runscript
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-19 02:57:50 UTC
This one is actually a bit weirder.

pkg_preinst() {
        [[ -s "${EROOT}"/etc/minicom/minirc.dfl ]] && rm -f "${ED}"/etc/minicom/minirc.dfl
}

"If the file exists on the real system we're about to install to and has size > 0, delete it from the image."

I _assume_ the idea here is to avoid clobbering the user's configuration, but it doesn't work like that. It just ends up clobbering it and Portage will *remove* it instead.

The file should be installed as orphaned to avoid interfering with users, or better yet, just rely on CONFIG_PROTECT.
Comment 3 Larry the Git Cow gentoo-dev 2023-03-19 06:51:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7aa4284f78b05a1f504631aedf95a95c2c8fc7f

commit d7aa4284f78b05a1f504631aedf95a95c2c8fc7f
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2023-03-19 06:27:24 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-03-19 06:49:33 +0000

    net-dialup/minicom: update EAPI 7 -> 8
    
    Remove weird /etc/minicom/minirc.dfl logic.
    
    Closes: https://bugs.gentoo.org/885709
    Closes: https://github.com/gentoo/gentoo/pull/30228
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 net-dialup/minicom/minicom-2.8-r2.ebuild | 60 ++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)