Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885707 - net-analyzer/zmap-2.1.1-r4: only installs config file on first install
Summary: net-analyzer/zmap-2.1.1-r4: only installs config file on first install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jakov Smolić
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-13 03:55 UTC by Agostino Sarubbo
Modified: 2023-03-19 03:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-13 03:55:36 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-analyzer/zmap-2.1.1-r4 installs less files with clang stricter.
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
To reproduce this issue:
1) Install the package with CC=clang - CXX=clang++
2) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist1 )
3) Install the package with CC=clang - CXX=clang++ - CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types
4) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist2 )
5) See the diff between the two files ( diff -ru /tmp/qlist_1 /tmp/qlist_2 )

On this machine:
- the installed files with clang are 10
- the installed files with clang stricter are 8

This type of report comes from a check that is a bit outside of the tinderbox, that's the reason because build.log was not provided (however in cases like these the build.log doesn't help much) but if you need further help to diagnose this issue feel free to ask.

In any case I'm providing a diff.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-13 03:56:01 UTC
DIFF:
--- /dev/fd/63  2022-12-13 00:11:24.479388159 +0100
+++ /dev/fd/62  2022-12-13 00:11:24.479388159 +0100
@@ -1,5 +1,3 @@
-/etc/zmap/blacklist.conf
-/etc/zmap/zmap.conf
 /usr/sbin/zblacklist
 /usr/sbin/zmap
 /usr/sbin/ztee
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-19 02:19:31 UTC
Reproduced:

[WW] CMP: =net-analyzer/zmap-2.1.1-r4 with net-analyzer/zmap-2.1.1-r4/image
[WW]  FILES:-etc/zmap/blacklist.conf
[WW]  FILES:-etc/zmap/zmap.conf
[WW]  FILES:-usr/sbin/zmap (-rwx--x--x root:root)
[WW]  FILES:+usr/sbin/zmap (-rwxr-xr-x root:root)
[WW]   SIZE: 1.52MiB -> 1.05MiB, 10 -> 8 files
[WW] ------> FILES(+1,-3) SIZE(-30.56%)
Comment 3 Larry the Git Cow gentoo-dev 2023-03-19 03:22:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26aef8c9f95ea9627701060c73022d6c12a120ca

commit 26aef8c9f95ea9627701060c73022d6c12a120ca
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-03-19 02:36:19 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-19 02:36:48 +0000

    net-analyzer/zmap: fix config file installation
    
    We always want to install configs as the host machine may be different from
    the one where zmap is installed to. Plus we have CONFIG_PROTECT in Gentoo
    for protecting the user's existing configuration.
    
    Unrelated to Clang 16, but an interesting bug! Sync live while at it.
    
    Closes: https://bugs.gentoo.org/885707
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/zmap-2.1.1-always-install-config.patch   | 20 ++++++++++++++++
 .../{zmap-2.1.1-r4.ebuild => zmap-2.1.1-r5.ebuild} | 27 ++++++++++++++--------
 net-analyzer/zmap/zmap-9999.ebuild                 | 21 +++++++++++------
 3 files changed, 52 insertions(+), 16 deletions(-)