Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885699 - net-ftp/linksys-tftp-1.2.1-r3 fails to compile (CLANG-STRICTER-SYSTEM): main.c:285:16: error: incompatible pointer to integer conversion passing char to parameter of type int [-Wint-conversion]
Summary: net-ftp/linksys-tftp-1.2.1-r3 fails to compile (CLANG-STRICTER-SYSTEM): main....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Embedded Gentoo Team
URL:
Whiteboard: fixed in 1.2.1-r4
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2022-12-13 03:43 UTC by Agostino Sarubbo
Modified: 2024-10-29 18:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,77.47 KB, text/plain)
2022-12-13 03:43 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-13 03:43:46 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-ftp/linksys-tftp-1.2.1-r3 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-13 03:43:48 UTC 
Created attachment 842331 [details]
build.log

build log and emerge --info
Comment 2 NHO 2024-03-25 13:19:17 UTC 
It's crusty K&R C. Last noted in to have updates in 2004. May need total rewrite...

Gentoo is only one distro to have this package.
Are routers that need this software still exist?
Comment 3 Larry the Git Cow gentoo-dev 2024-04-29 05:32:04 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9041943e464b5d219db2101df1eebcab907e4b60

commit 9041943e464b5d219db2101df1eebcab907e4b60
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2024-04-24 10:59:21 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2024-04-29 05:18:39 +0000

    net-ftp/linksys-tftp: Port to C99, fix compile on musl systems
    
    Primary patch by Richard Narron from bug 928051
    Musl fix by me.
    
    Closes: https://bugs.gentoo.org/928051
    Closes: https://bugs.gentoo.org/714212
    Closes: https://bugs.gentoo.org/874582
    Closes: https://bugs.gentoo.org/885699
    Closes: https://bugs.gentoo.org/913577
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/36399
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 .../files/linksys-tftp-1.2.1-r4-c99-port.patch     | 572 +++++++++++++++++++++
 net-ftp/linksys-tftp/linksys-tftp-1.2.1-r4.ebuild  |  31 ++
 2 files changed, 603 insertions(+)