Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885527 - media-sound/bristol-0.60.11-r2 fails to compile (CLANG-STRICTER-SYSTEM): audioGUI.c:162:29: error: parameter controller was not declared, defaults to int; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
Summary: media-sound/bristol-0.60.11-r2 fails to compile (CLANG-STRICTER-SYSTEM): audi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard: fixed in 0.60.11-r3
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2022-12-12 09:52 UTC by Agostino Sarubbo
Modified: 2024-10-29 17:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,82.77 KB, text/plain)
2022-12-12 09:52 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-12 09:52:32 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/bristol-0.60.11-r2 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-12 09:52:34 UTC 
Created attachment 841639 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2024-03-18 05:31:33 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d556c93b3cd1f4b3fc814192dedb0e89732e307

commit 5d556c93b3cd1f4b3fc814192dedb0e89732e307
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-18 00:26:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-18 05:29:56 +0000

    media-sound/bristol: apply Florian's patch for Modern C
    
    Fixes many instances of -Werror=implicit-int. Modern C changes mean
    accompanying revbump for possibly-dangerous codegen flaws being
    corrected.
    
    Closes: https://bugs.gentoo.org/885527
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/bristol/bristol-0.60.11-r3.ebuild |  62 ++++++
 media-sound/bristol/files/bristol-c99.patch   | 268 ++++++++++++++++++++++++++
 2 files changed, 330 insertions(+)