Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 885447 - app-text/zathura-pdf-mupdf-0.4.0: version bump and dependency issue
Summary: app-text/zathura-pdf-mupdf-0.4.0: version bump and dependency issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Philipp Rösner
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PullRequest
Depends on: 885445
Blocks:
  Show dependency tree
 
Reported: 2022-12-11 13:48 UTC by Eric Stein
Modified: 2023-01-09 08:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-text/zathura-pdf-mupdf-0.4.0.ebuild (zathura-pdf-mupdf-0.4.0.ebuild,745 bytes, text/plain)
2022-12-11 13:49 UTC, Eric Stein
Details
app-text/files/zathura-pdf-mupdf-0.4.0-meson-mupdfthird.patch (zathura-pdf-mupdf-0.4.0-meson-mupdfthird.patch,1.10 KB, patch)
2022-12-11 13:50 UTC, Eric Stein
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Stein 2022-12-11 13:48:43 UTC
zathura-pdf-mupdf 0.4.0 was released.

Since 0.3.8, the detection of mupdf was simplified[1]. More precisely it is assumed that the prebuild or the debian build libmupdf is found.

mupdf can be build with app-text/tesseract and media-libs/leptonica, but the available ebuilds in portage don't support this.

I have attached a modified meson patch.

In addition the, mujs build dependency should be guarded by a javascript USE-Flag which requires, that mupdf is build with the same flag.

I'm not sure about two things:
1. How zathura-pdf-mupdf behaves, when mupdf is build with mujs and zathura-pdf-mupdf itself isn't.
2. If it is better to remove it from meson.build with sed or add a second patch.

Regards,
eric

[1] see comments on gitlab: pwmt/zathura-pdf-mupdf/-/commit/49a85efb915bfed933d251f6074b807d0e1ef385
I will post the link completly, after the 24h timeout.

Reproducible: Always
Comment 1 Eric Stein 2022-12-11 13:49:25 UTC
Created attachment 841343 [details]
app-text/zathura-pdf-mupdf-0.4.0.ebuild
Comment 2 Eric Stein 2022-12-11 13:50:19 UTC
Created attachment 841345 [details, diff]
app-text/files/zathura-pdf-mupdf-0.4.0-meson-mupdfthird.patch
Comment 3 Philipp Rösner 2022-12-14 22:33:28 UTC
Greetings,

thanks a lot for the ebuild suggestion and the modified patch.
I can verify that there is currently no support to build app-text/mupdf
with app-text/tesseract and media-libs/leptonica.
As I also maintain app-text/mupdf, I will think about how to integrate them into the app-text/mupdf ebuild.

For now it is true that these dependencies aren't needed in the app-text/zathura-pdf-mupdf ebuild, so it makes sense to remove them.

I agree that the mujs dependency should be guarded by the mujs USE flag set in app-text/mupdf. I will integrate that into the new ebuild.

I will try to get the zathura-pdf-mupdf-0.4.0 ready by tomorrow.

Regards,
Philipp
Comment 4 Larry the Git Cow gentoo-dev 2023-01-09 08:33:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6c6e6c69f1ee6323f770f9531424dce095bd4a3

commit e6c6e6c69f1ee6323f770f9531424dce095bd4a3
Author:     Philipp Rösner <rndxelement@protonmail.com>
AuthorDate: 2022-12-15 22:25:58 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2023-01-09 08:33:18 +0000

    app-text/zathura-pdf-mupdf: add 0.4.0
    
    Also remove build deps that are not actually required and
    add a USE flag `javascript` which requires app-text/mupdf
    to be built with `javascript` enabled and removes mujs
    deps from meson.build if `javascript` not enabled.
    
    Closes: https://bugs.gentoo.org/885447
    Suggested-by: Eric Stein <ericzwo@proton.me>
    Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-text/zathura-pdf-mupdf/Manifest                |  1 +
 .../zathura-pdf-mupdf-0.4.0-meson-mupdfthird.patch | 39 ++++++++++++++++++
 .../zathura-pdf-mupdf-0.4.0.ebuild                 | 46 ++++++++++++++++++++++
 3 files changed, 86 insertions(+)