Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 884447 - [guru] net-p2p/p2pool-2.6-r1 installs pre-stripped files
Summary: [guru] net-p2p/p2pool-2.6-r1 installs pre-stripped files
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adam
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-12-05 11:11 UTC by Agostino Sarubbo
Modified: 2022-12-14 16:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,72.67 KB, text/plain)
2022-12-05 11:11 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-05 11:11:19 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-p2p/p2pool-2.6-r1 installs pre-stripped files.
Discovered on: amd64 (internal ref: guru_ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-05 11:11:22 UTC
Created attachment 840215 [details]
build.log

build log and emerge --info
Comment 2 Adam 2022-12-05 17:52:42 UTC
the 'file' command reports the binary as stripped for some reason. Should I still add dostrip to src_install() ?
Comment 3 Viorel Munteanu gentoo-dev 2022-12-06 06:20:14 UTC
Normally the files should not be stripped by default.  Portage will strip them, but the user can enable FEATURE `nostrip` to keep the debug info in executables, see here https://wiki.gentoo.org/wiki/Debugging

This is the reason for this bug.  For binary packages, if the executables are already stripped, you can add them to QA_PRESTRIPPED or even QA_PREBUILT, see here https://devmanual.gentoo.org/eclass-reference/ebuild/index.html
Comment 4 Adam 2022-12-10 02:47:35 UTC
(In reply to Viorel Munteanu from comment #3)
> Normally the files should not be stripped by default.  Portage will strip
> them, but the user can enable FEATURE `nostrip` to keep the debug info in
> executables, see here https://wiki.gentoo.org/wiki/Debugging
> 
> This is the reason for this bug.  For binary packages, if the executables
> are already stripped, you can add them to QA_PRESTRIPPED or even
> QA_PREBUILT, see here
> https://devmanual.gentoo.org/eclass-reference/ebuild/index.html

Okay, I have it producing unstripped files when "nostrip" is on. Take a look at the ebuild and tell me if that looks about right.
Comment 5 Adam 2022-12-10 04:28:22 UTC
oh crap, wrong package. Yeah, I can't figure out how to get this to stop stripping the binary, sorry.
Comment 6 Larry the Git Cow gentoo-dev 2022-12-14 16:46:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=3c50f669432bad09c6c469d78f6d6889853a8010

commit 3c50f669432bad09c6c469d78f6d6889853a8010
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2022-12-10 07:55:23 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2022-12-10 07:55:23 +0000

    net-p2p/p2pool: don't strip files by default
    
    Closes: https://bugs.gentoo.org/884447
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 net-p2p/p2pool/p2pool-2.6-r1.ebuild | 9 +++++++++
 net-p2p/p2pool/p2pool-9999.ebuild   | 9 +++++++++
 2 files changed, 18 insertions(+)