Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 884049 - net-voip/mumble-1.4.287 fails to compile on x86
Summary: net-voip/mumble-1.4.287 fails to compile on x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Kenton Groombridge
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 877665
  Show dependency tree
 
Reported: 2022-12-02 19:22 UTC by Arthur Zamarin
Modified: 2022-12-06 19:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,110.40 KB, text/plain)
2022-12-02 19:22 UTC, Arthur Zamarin
Details
build.log with patch applied, with failing tests (build.log,534.58 KB, text/x-log)
2022-12-05 18:36 UTC, Arthur Zamarin
Details
LastTest.log (LastTest.log,49.58 KB, text/x-log)
2022-12-05 18:37 UTC, Arthur Zamarin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-12-02 19:22:49 UTC
Created attachment 839093 [details]
build.log

x86-stable container on devbox.amd64.d.g.o

Fails on:

> In file included from /var/tmp/portage/net-voip/mumble-1.4.287/work/mumble-1.4.287.src/plugins/gtav/Game.h:9,
>                  from /var/tmp/portage/net-voip/mumble-1.4.287/work/mumble-1.4.287.src/plugins/gtav/gtav.cpp:6:
> /var/tmp/portage/net-voip/mumble-1.4.287/work/mumble-1.4.287.src/plugins/gtav/structs.h:218:37: error: static assertion failed
>   218 | static_assert(sizeof(CCameraAngles) == 0x408, "");
>       |               ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
Comment 1 Kenton Groombridge gentoo-dev 2022-12-02 22:45:10 UTC
Looks like this was fixed upstream some time ago: https://github.com/mumble-voip/mumble/commit/13c051b36b387356815cff5d685bc628b74ba136

Does this patch fix the build? If so I'll include it in a revbump.
Comment 2 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-12-05 18:36:47 UTC
Created attachment 840251 [details]
build.log with patch applied, with failing tests

(In reply to Kenton Groombridge from comment #1)
> Looks like this was fixed upstream some time ago:
> https://github.com/mumble-voip/mumble/commit/
> 13c051b36b387356815cff5d685bc628b74ba136
> 
> Does this patch fix the build? If so I'll include it in a revbump.

Yes, now it compiles fine (please add the patch to ebuild), but some tests are failing. Could you say if this is fine?
Also, if those are expected, maybe it would be worth to skip them in ebuild (just an idea we use a lot in @python packages).
Comment 3 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-12-05 18:37:12 UTC
Created attachment 840253 [details]
LastTest.log
Comment 4 Kenton Groombridge gentoo-dev 2022-12-05 18:57:36 UTC
It looks like upstream also saw similar issues in the past with that particular set of tests timing out: https://github.com/mumble-voip/mumble/pull/4377

Their solution was just to increase the timeout. Could you try doing the same?
Comment 5 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-12-05 19:55:22 UTC
(In reply to Kenton Groombridge from comment #4)
> It looks like upstream also saw similar issues in the past with that
> particular set of tests timing out:
> https://github.com/mumble-voip/mumble/pull/4377
> 
> Their solution was just to increase the timeout. Could you try doing the
> same?

Yes, adding `export QTEST_FUNCTION_TIMEOUT=600000` worked and passed all tests.

Can you please update the ebuild (I think it needs a revbump?) and I will stabilize for x86 (no need for extra 30 days wait) :)
Comment 6 Larry the Git Cow gentoo-dev 2022-12-06 19:36:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1fa9229b7486ee0986d3486cddd65e209d770084

commit 1fa9229b7486ee0986d3486cddd65e209d770084
Author:     Kenton Groombridge <concord@gentoo.org>
AuthorDate: 2022-12-06 19:28:31 +0000
Commit:     Kenton Groombridge <concord@gentoo.org>
CommitDate: 2022-12-06 19:35:56 +0000

    net-voip/mumble: fix 1.4.287 build on x86, increase tests timeout
    
    Closes: https://bugs.gentoo.org/884049
    Signed-off-by: Kenton Groombridge <concord@gentoo.org>

 .../mumble/files/mumble-1.4-force-alignment.patch  | 28 ++++++++++++++++++++++
 ...ble-1.4.287.ebuild => mumble-1.4.287-r1.ebuild} | 10 +++++++-
 2 files changed, 37 insertions(+), 1 deletion(-)