media-plugins/hdx-realtime-media-engine is an optional plugin for net-misc/icaclient it enabled better multimedia UX when MS teams is used on the remote desktop The application itself contains some binaries that depend on some libraries, but the binaries and the deps do not make sense without the plugin. One could say that the upstream package split by the vendor is off. At the time of writing that is mainly about the binary "/opt/Citrix/ICAClient/util/HdxRtcEngine" and sys-libs/llvm-libunwind which it needs, but the binary is only relevant when the plugin is installed. See: https://bugs.gentoo.org/881637 and there is a history of other bugs that try to git rid of QA reports by repackaging or pulling in deps that cause conflicts Repackaging is simply a bad idea, given upstream does not even get the package split right. One more problem is that the application and the plugin kind of share a file, when the plugin is installed it needs to be enabled in a file owned by the application but not under CONFIG_PROTECT. That is currently implemented with a weird hack in postinst of both ebuilds where a file called "module.ini" needs to be modified depending on whether the plugin is installed. Reproducible: Always
To solve this i will propose to merge both ebuilds into just one and modeling the plugin with a USE flag. ... maybe "hdx" ? That should allow to know when to pull in libs as deps, will make the "module.ini" owned/controlled by only one ebuild. We will try to "merge" the "incorrect split", hopefully reduce maint effort and issues.
I will propose that with the upcoming 22.12 release of icaclient.
please assign to me
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9fc0e563e8d4c73be09fd6ae98b679d1927fe8e commit c9fc0e563e8d4c73be09fd6ae98b679d1927fe8e Author: Henning Schild <henning@hennsch.de> AuthorDate: 2022-12-01 14:40:48 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-24 06:55:50 +0000 net-misc/icaclient: bump to 22.12.0.12 Here we do not just bump the version but also change the way we deal with the shared config file between this ebuild and its plugin media-plugins/hdx-realtime-media-engine. Also we move the rdep to sys-libs/llvm-libunwind to the plugin. And if the user wants hdx support on icaclient they have to set a USE flag. The plugin will not work if icaclient is not built with support for it and the plugin itself contains the tool to enable itself so we turn the dep chain around, the plugin is even a bdep of the application. Closes: https://bugs.gentoo.org/883775 Closes: https://bugs.gentoo.org/881637 Signed-off-by: Henning Schild <henning@hennsch.de> Closes: https://github.com/gentoo/gentoo/pull/28493 Signed-off-by: Sam James <sam@gentoo.org> ...dx-realtime-media-engine-2.9.500.2802-r1.ebuild | 88 +++++++ net-misc/icaclient/Manifest | 2 + net-misc/icaclient/icaclient-22.12.0.12.ebuild | 276 +++++++++++++++++++++ net-misc/icaclient/metadata.xml | 3 + 4 files changed, 369 insertions(+)
