Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 883729 - net-analyzer/monitoring-plugins fails after system update to net-misc/iputils-20221126
Summary: net-analyzer/monitoring-plugins fails after system update to net-misc/iputils...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords:
Depends on: 883793
Blocks:
  Show dependency tree
 
Reported: 2022-11-30 12:40 UTC by Reuben Farrelly
Modified: 2023-02-05 21:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Reuben Farrelly 2022-11-30 12:40:39 UTC
With net-analyzer/monitoring-plugins (all ebuilds in tree) there is this statement:

    # The autodetection for these two commands can hang if localhost is
    # down or ICMP traffic is filtered. Bug #468296.
    myconf+=( --with-ping-command="/bin/ping -4 -n -U -w %d -c %d %s" )

    if use ipv6; then
        myconf+=( --with-ping6-command="/bin/ping -6 -n -U -w %d -c %d %s" )
    fi

This hard coded path means there is a run-time dependency on ping being located in /bin/ping.

However after upgrading iputils to version 20221126 which has just appeared in the tree, ping is now located in:

/usr/bin/ping     and not /bin/ping

This causes runtime issues, because as soon as iputils is updated, the check_ping plugin in monitoring-plugins causes all reachability tests to fail due to the changed path.

A rebuild of monitoring-plugins is not sufficient on its own, but after updating the ebuild with the new path for ping and ping6 then a rebuild resolves the issue.

In https://bugs.gentoo.org/565500 there is a similar problem with some commentary about approaches to fixes.
Comment 1 Larry the Git Cow gentoo-dev 2022-12-01 01:00:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a5ad2e371f409ab9b41a7f7fedc766dd0fc0c2e

commit 1a5ad2e371f409ab9b41a7f7fedc766dd0fc0c2e
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2022-12-01 00:46:12 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2022-12-01 00:58:42 +0000

    net-analyzer/monitoring-plugins: new revisions to fix ping path.
    
    We pass explicit ping/ping6 commands to the monitoring-plugins
    ./configure script to prevent it from running those commands during the
    build. However, instead of grabbing their paths from $PATH, we have
    (until now) hard-coded them to /bin/ping. This has now bitten us with
    net-misc/iputils-20221126.
    
    This commit uses $(command -v ...) to get the right absolute
    paths. Thanks to Daniel Pouzzner for reporting the problem and
    suggesting the near-identical fix to nagios-plugins. I've made the
    changes and revisions to both the ~arch and stable ebuilds to avoid as
    much breakage as possible, but we will still need to coordinate the
    stabilization of monitoring-plugins-2.3.2-r1 with iputils-20221126.
    
    Closes: https://bugs.gentoo.org/883729
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 ...-plugins-2.3.1-r3.ebuild => monitoring-plugins-2.3.1-r4.ebuild} | 7 ++++---
 ...ing-plugins-2.3.2.ebuild => monitoring-plugins-2.3.2-r1.ebuild} | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)
Comment 2 Michael Orlitzky gentoo-dev 2022-12-01 01:03:41 UTC
I did damage control, but we'll have to be careful to make sure the same thing doesn't happen when iputils gets stabilized (bug #883793).