Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 883447 - media-gfx/realesrgan-ncnn-vulkan-0.2.0 fails with -n realesrnet-x4plus
Summary: media-gfx/realesrgan-ncnn-vulkan-0.2.0 fails with -n realesrnet-x4plus
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Piotr Karbowski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-28 17:55 UTC by Pacho Ramos
Modified: 2022-12-05 08:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2022-11-28 17:55:08 UTC
It seems it fails to find the proper path for the files:
$ realesrgan-ncnn-vulkan -i -008.png -o output4.png -n realesrnet-x4plus
MESA-INTEL: warning: Performance support disabled, consider sysctl dev.i915.perf_stream_paranoid=0
[0 Intel(R) HD Graphics 530 (SKL GT2)]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[0 Intel(R) HD Graphics 530 (SKL GT2)]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 Intel(R) HD Graphics 530 (SKL GT2)]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 Intel(R) HD Graphics 530 (SKL GT2)]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1
fopen /usr/bin//usr/share/realesrgan-ncnn-vulkan/models/realesrnet-x4plus.param failed
fopen /usr/bin//usr/share/realesrgan-ncnn-vulkan/models/realesrnet-x4plus.bin failed
find_blob_index_by_name data failed

It works fine for all the other modes

Thanks
Comment 1 Piotr Karbowski (RETIRED) gentoo-dev 2022-11-28 22:36:07 UTC
I will need to patch the readme that it prints as it seems upstream never really updated it. The following models are bundled:

- realesrgan-x4plus
- realesrgan-x4plus-anime
- realesr-animevideov3-

You can inspect it by looking into /usr/share/realesrgan-ncnn-vulkan/models. While at it I will also make realesrgan-x4plus the default one.
Comment 2 Piotr Karbowski (RETIRED) gentoo-dev 2022-11-28 22:41:06 UTC
Actually I found that realesrnet-x4plus is present in https://github.com/xinntao/Real-ESRGAN/releases/download/v0.2.3.0/realesrgan-ncnn-vulkan-20211212-ubuntu.zip so I will extract it and bundle in revbump along with the patches as described above. For now you can fetch the binary package and use it's models directory to get it.
Comment 3 Piotr Karbowski (RETIRED) gentoo-dev 2022-12-03 22:47:18 UTC
Looks like hook has not fired.

commit acd95beeaa5fc1ab54a325aa5f0c63fea3dfc94e (HEAD -> master)
Author: Piotr Karbowski <slashbeast@gentoo.org>
Date:   2022-12-03 23:44:24 +0100

    media-gfx/realesrgan-ncnn-vulkan: new default model; added missing model.

    Closes: https://bugs.gentoo.org/883447
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 media-gfx/realesrgan-ncnn-vulkan/Manifest                                                                        |  2 +-
 media-gfx/realesrgan-ncnn-vulkan/files/realesrgan-ncnn-vulkan-default-realesrgan-x4plus-model.patch              | 22 ++++++++++++++++++++++
 media-gfx/realesrgan-ncnn-vulkan/{realesrgan-ncnn-vulkan-0.2.0.ebuild => realesrgan-ncnn-vulkan-0.2.0-r1.ebuild} |  6 +++++-
 3 files changed, 28 insertions(+), 2 deletions(-)
Comment 4 Pacho Ramos gentoo-dev 2022-12-04 09:22:18 UTC
thanks a lot!
Comment 5 Larry the Git Cow gentoo-dev 2022-12-04 09:56:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8812cf3de296cbf347557b4df493ba7dfd744e6

commit e8812cf3de296cbf347557b4df493ba7dfd744e6
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2022-12-04 09:55:32 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2022-12-04 09:55:32 +0000

    media-gfx/realesrgan-ncnn-vulkan: new default model; added missing model.
    
    Closes: https://bugs.gentoo.org/883447
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 media-gfx/realesrgan-ncnn-vulkan/Manifest          |  2 +-
 .../realesrgan-ncnn-vulkan-0.2.0.ebuild            | 56 ----------------------
 2 files changed, 1 insertion(+), 57 deletions(-)
Comment 6 Piotr Karbowski (RETIRED) gentoo-dev 2022-12-04 09:57:46 UTC
Sorry about missing commit in tree, I had typo in updated script and actually it debased me on the top of origin/master but not pushed. You have fixes now in ::gentoo.
Comment 7 Ionen Wolkens gentoo-dev 2022-12-04 19:48:11 UTC
The last commit removed the last ebuild, leaving only a Manifest and metadata.xml
Comment 8 Ionen Wolkens gentoo-dev 2022-12-04 19:50:09 UTC
(In reply to Ionen Wolkens from comment #7)
> The last commit removed the last ebuild, leaving only a Manifest and
> metadata.xml
ftr should be caught by pkgcheck and reported by CI normally, but seems there's some issue with pkgcheck (being looked into).
Comment 9 Piotr Karbowski (RETIRED) gentoo-dev 2022-12-04 19:55:26 UTC
That was unbelievably sloppy of me.
Comment 10 Larry the Git Cow gentoo-dev 2022-12-04 19:57:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a658456988ef9af02904355dc785352ed19eb105

commit a658456988ef9af02904355dc785352ed19eb105
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2022-12-04 19:56:23 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2022-12-04 19:57:43 +0000

    media-gfx/realesrgan-ncnn-vulkan: Add missing files.
    
    Bug: https://bugs.gentoo.org/883447
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 ...nn-vulkan-default-realesrgan-x4plus-model.patch | 22 ++++++++
 .../realesrgan-ncnn-vulkan-0.2.0-r1.ebuild         | 60 ++++++++++++++++++++++
 2 files changed, 82 insertions(+)
Comment 11 Piotr Karbowski (RETIRED) gentoo-dev 2022-12-05 08:51:15 UTC
To keep this covered, I added a pre-commit hook that will refuse to make a commit if there's any metadata.xml, manifest or *.ebuild that is not git added, so this will not happen again.