Bug 883413 – sys-libs/db-5.3.28-r8 fails to compile (CLANG-STRICTER-SYSTEM): dbstl_common.h:57:2: error: "No appropriate TLS modifier defined."

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-11-28 12:41:34 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-libs/db-5.3.28-r8 fails to compile (CLANG-STRICTER-SYSTEM).
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 1 Agostino Sarubbo 2022-11-28 12:41:36 UTC]

Created attachment 837953 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Sam James 2022-12-07 15:39:27 UTC]

*** Bug 883879 has been marked as a duplicate of this bug. ***

[Comment 3 Sam James 2023-02-11 05:24:41 UTC]

With db-5.3.28-r8 I also get:
```
-ignoreme: warning: incompatible function pointer types passing 'int ()' to parameter of type '__sighandler_t' (aka 'void (*)(int)') [-Wincompatible-function-pointer-types]
+ignoreme: error: incompatible function pointer types passing 'int ()' to parameter of type '__sighandler_t' (aka 'void (*)(int)') [-Werror,-Wincompatible-function-pointer-types]
             (void) signal(SIGSEGV, catch_sig);
                                    ^~~~~~~~~
```

[Comment 4 Larry the Git Cow 2023-02-12 02:04:32 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e2da48dc49a0d45dc9d6bcc0553c9dd94a66b0e

commit 7e2da48dc49a0d45dc9d6bcc0553c9dd94a66b0e
Author:     Sam James <[e-mail]>
AuthorDate: 2023-02-12 02:02:13 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-02-12 02:04:14 +0000

    sys-libs/db: fix configure w/ clang 16
    
    Closes: https://bugs.gentoo.org/883413
    Signed-off-by: Sam James <[e-mail]>

 .../{db-4.8.30-r7.ebuild => db-4.8.30-r8.ebuild}   |   3 +-
 .../{db-5.3.28-r8.ebuild => db-5.3.28-r9.ebuild}   |   3 +-
 sys-libs/db/files/db-4.8.30-clang16.patch          | 281 ++++++++++++++++++
 sys-libs/db/files/db-5.3.28-clang16.patch          | 325 +++++++++++++++++++++
 4 files changed, 610 insertions(+), 2 deletions(-)