Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 883409 - dev-util/rocm-smi-5.4.2 does not respect LDFLAGS
Summary: dev-util/rocm-smi-5.4.2 does not respect LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ldflags
  Show dependency tree
 
Reported: 2022-11-28 12:32 UTC by Agostino Sarubbo
Modified: 2025-01-05 21:49 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,99.59 KB, text/plain)
2022-11-28 12:33 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-28 12:32:59 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/rocm-smi-5.1.3 does not respect LDFLAGS.
Discovered on: amd64 (internal ref: clang-stricter_tinderbox)

NOTE:
(CLANG-STRICTER-SYSTEM) in the summary means that the bug was found on a machine that runs clang with stricter mode

This machine uses clang with CFLAGS/CXXFLAGS=-Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-function-pointer-types

See also:
https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
https://wiki.gentoo.org/wiki/Modern_C_porting
To reproduce this issue you may want to set LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ context you may want to see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect LDFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-28 12:33:01 UTC
Created attachment 837949 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-02-22 08:27:08 UTC
tinderbox_musl has reproduced this issue with version 5.4.2 - Updating summary.
Comment 3 Larry the Git Cow gentoo-dev 2025-01-05 21:49:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e588faf2bcca734a5f2f5fc7df7430ee52539a6b

commit e588faf2bcca734a5f2f5fc7df7430ee52539a6b
Author:     Sv. Lockal <lockalsash@gmail.com>
AuthorDate: 2024-12-08 14:02:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-05 21:46:29 +0000

    dev-util/rocm-smi: add 6.3.0, drop 9999
    
    Closes: https://bugs.gentoo.org/883409
    Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/rocm-smi/Manifest                         |   1 +
 .../rocm-smi/files/rocm-smi-6.3.0-fix-flags.patch  |  34 +++++++
 .../files/rocm-smi-6.3.0-set-soversion.patch       | 104 +++++++++++++++++++++
 ...{rocm-smi-9999.ebuild => rocm-smi-6.3.0.ebuild} |  31 +++---
 4 files changed, 156 insertions(+), 14 deletions(-)