Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 883157 - app-backup/timeshift: fails to build parallel
Summary: app-backup/timeshift: fails to build parallel
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Contributor problems (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ross Charles C.
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: parallel-make
  Show dependency tree
 
Reported: 2022-11-26 14:51 UTC by Pascal Jäger
Modified: 2023-10-16 05:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emergeinfo-timeshift,9.74 KB, text/plain)
2022-11-26 14:52 UTC, Pascal Jäger
Details
emerge -pqv (emergepqv-timeshift,117 bytes, text/plain)
2022-11-26 14:53 UTC, Pascal Jäger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Jäger 2022-11-26 14:51:28 UTC
during compile phase I get many errors like 
`cc1: fatal error: /var/tmp/portage/app-backup/timeshift-22.06.5/work/timeshift-22.06.5/src/Utility/AppLock.vala.c: No such file or directory
compilation terminated.`

I watched the directory /var/tmp/portage/app-backup/timeshift-22.06.5/work/timeshift-22.06.5/src/Utility/ during compilation and those files are indeed created but later deleted again. 

When I am using make instead of emake in the ebuild, it works. 

Build log: http://ix.io/4gVC
Comment 1 Pascal Jäger 2022-11-26 14:52:47 UTC
Created attachment 837165 [details]
emerge --info
Comment 2 Pascal Jäger 2022-11-26 14:53:35 UTC
Created attachment 837167 [details]
emerge -pqv
Comment 3 Florian Schmaus gentoo-dev 2022-11-26 17:04:12 UTC
FWIW, emake is just a thing wrapper around make, basically
    ${MAKE:-make} ${MAKEOPTS} "$@" ${EXTRA_EMAKE}
with return code checking. It is unlikely the cause of the build failure.

Please also coordinate changes with the package maintainer.
Comment 4 Andrew Ammerlaan gentoo-dev 2022-11-26 17:54:44 UTC
> When I am using make instead of emake in the ebuild, it works. 

Then the problem is probably with parallelization. As Florian explained emake takes the MAKEOPTS into account so the problem is likely there.

If you use emake and emerge with MAKEOPTS="-j1" does this fix your problem?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-26 19:48:33 UTC
Please always attach logs rather than using pastebins as they expire and/or may not be accessible.
Comment 6 Pascal Jäger 2022-11-29 13:35:59 UTC
emake -j1 does the trick. Thanks.

(In reply to Florian Schmaus from comment #3)
> Please also coordinate changes with the package maintainer.

The maintainer had his last commit to the GURU in mid 2021. In fact I did the last two bump for that thing. 
I think timeshift should go into ::gentoo anyway.
Comment 7 Larry the Git Cow gentoo-dev 2022-12-01 03:59:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2f3819234495661e8746bef037fd6aa87b404dbb

commit 2f3819234495661e8746bef037fd6aa87b404dbb
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-11-29 13:28:04 +0000
Commit:     Pascal Jäger <pascal.jaeger@leimstift.de>
CommitDate: 2022-11-29 13:28:04 +0000

    app-backup/timeshift: use emake -j1
    
    Closes: https://bugs.gentoo.org/883157
    
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>

 app-backup/timeshift/Manifest                                       | 4 ++--
 .../{timeshift-21.09.1-r2.ebuild => timeshift-21.09.1-r3.ebuild}    | 6 +++---
 .../{timeshift-22.06.5-r1.ebuild => timeshift-22.06.5-r2.ebuild}    | 6 +++---
 .../{timeshift-22.11.1.ebuild => timeshift-22.11.1-r1.ebuild}       | 6 +++---
 4 files changed, 11 insertions(+), 11 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=2ce474cacfcfcf2e0d3ba724f28c6b5872244f21

commit 2ce474cacfcfcf2e0d3ba724f28c6b5872244f21
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-11-26 15:15:37 +0000
Commit:     Pascal Jäger <pascal.jaeger@leimstift.de>
CommitDate: 2022-11-26 15:18:06 +0000

    app-backup/timeshift-21.09.1: revbump, use make instead of emake
    
        - update xdg icon cache after install
    
        Bug: https://bugs.gentoo.org/849626
        Bug: https://bugs.gentoo.org/849629
        Bug: https://bugs.gentoo.org/883157
    
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>

 ....09.1-r1.ebuild => timeshift-21.09.1-r2.ebuild} | 23 +++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=707031ef7c74098969e56df60ca56f23547fee1a

commit 707031ef7c74098969e56df60ca56f23547fee1a
Author:     Pascal Jäger <pascal.jaeger@leimstift.de>
AuthorDate: 2022-11-26 15:08:28 +0000
Commit:     Pascal Jäger <pascal.jaeger@leimstift.de>
CommitDate: 2022-11-26 15:18:06 +0000

    app-backup/timeshift-22.06.5: revbump, use make instead of emake
    
    - update xdg icon cache after install
    
    Closes: https://bugs.gentoo.org/849626
    Closes: https://bugs.gentoo.org/849629
    Bug: https://bugs.gentoo.org/883157
    
    Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>

 app-backup/timeshift/Manifest                               |  2 +-
 ...timeshift-22.06.5.ebuild => timeshift-22.06.5-r1.ebuild} | 13 +++++++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)
Comment 8 Florian Schmaus gentoo-dev 2022-12-01 08:01:30 UTC
Re-opening, as we keep tickets for parallel build issues open until the bug is fixed upstream. This would be a good time to report the issue upstream, if not done already.

Also, I am not 100% sure, but appending "-j1" to the emake may not really fix the issue. It depends on how make handles multiple -j arguments. If it only considers the last one, then it should work, but if it considers only the first one, then it would still potentially result in a parallel build.

See https://wiki.gentoo.org/wiki/Troubleshooting_parallel_builds for more information and the canonical solution.
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-01 08:20:43 UTC
(In reply to Florian Schmaus from comment #8)
> Re-opening, as we keep tickets for parallel build issues open until the bug
> is fixed upstream. This would be a good time to report the issue upstream,
> if not done already.
>

Fwiw this isn't something we tend to do now unless there's a realistic prospect of it being fixed (alive upstream or maintainer wants to fix it)

> Also, I am not 100% sure, but appending "-j1" to the emake may not really
> fix the issue. It depends on how make handles multiple -j arguments. If it
> only considers the last one, then it should work, but if it considers only
> the first one, then it would still potentially result in a parallel build.
> 

We'd be in a lot of trouble if last didn't win, as we rely on this in a lot of places. Same for compiler args.

> See https://wiki.gentoo.org/wiki/Troubleshooting_parallel_builds for more
> information and the canonical solution.
Comment 10 Pascal Jäger 2023-10-16 05:52:47 UTC
Upstream switched to meson which builds fine in parallel now.