881389 – app-office/libreoffice-7.5.x: RISC-V and loong keywordreq

Bug 881389 - app-office/libreoffice-7.5.x: RISC-V and loong keywordreq

Summary: app-office/libreoffice-7.5.x: RISC-V and loong keywordreq

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Keywording (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Office Team

URL:
Whiteboard:	loong fix in git master
Keywords:	CC-ARCHES, PATCH, UPSTREAM

Depends on:
Blocks:

Reported:	2022-11-15 11:13 UTC by Yixun Lan
Modified:	2023-04-11 19:19 UTC (History)
CC List:	5 users (show)

See Also:	866221 https://github.com/autoconf-archive/autoconf-archive/pull/273 https://gerrit.libreoffice.org/c/core/+/147185
Package list:	app-office/libreoffice riscv loong app-office/libreoffice-l10n riscv loong app-text/libnumbertext riscv app-text/libstaroffice riscv dev-cpp/libcmis riscv dev-libs/liborcus riscv games-engines/box2d riscv sci-libs/coinor-mp riscv sci-mathematics/lpsolve riscv sys-devel/ucpp riscv dev-libs/libixion riscv dev-util/cppcheck riscv sci-libs/coinor-cbc riscv sci-libs/coinor-cgl riscv sci-libs/coinor-clp riscv sci-libs/coinor-osi riscv sci-libs/coinor-utils riscv sci-libs/coinor-dylp riscv sci-libs/coinor-sample riscv sci-libs/coinor-vol riscv sci-libs/mumps riscv sci-libs/parmetis riscv sci-libs/scalapack riscv
Runtime testing required:	---

Flags:	nattka: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yixun Lan archtester

2022-11-15 11:13:07 UTC

Patch was officially added to support RISC-V 64-bit (RISCV64) for Libreoffice, thus I'm opening this bug for enabling the RISC-V port support.

And I've tested the patch against app-office/libreoffice-7.3.7.2, which works fine on unmatched board - able to use the Writer, etc

The upstream commit can be seen here:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc9487f745befde6534fd46058e119256952323d&utm_source=anzwix

Reproducible: Always

Comment 1 Yixun Lan archtester

2022-11-18 07:42:33 UTC

hi @office, this patch backported from upstream should be quite safe to apply to,
I also tested in amd64 machine which works fine.

I'm also willing to help in the future, in case we need more testing or doing the version bump.

I've sent a PR for review, and stored the patch in my devspace.

thanks

Comment 2 Yixun Lan archtester

2022-11-23 23:58:12 UTC

@office, gently ping for this

is there any thing holding this? can you guys give an ACK?
or if no response, I will push this in one week (at Dec 1st)

Comment 3 Andreas Sturmlechner gentoo-dev

2022-11-24 10:44:06 UTC

Do not push this on your own without maintainer review please.

This is likely postponed for inclusion into a 7.4 release ebuild.

Comment 4 Yixun Lan archtester

2022-12-01 11:43:47 UTC

(In reply to Andreas Sturmlechner from comment #3)
> Do not push this on your own without maintainer review please.
> 
> This is likely postponed for inclusion into a 7.4 release ebuild.

Ok, fair enough, then I will re-ping once the 7.4 release out

And in the mean time, I've pushed 7.3.7.2 to riscv overlay[1], so if anyone wants to try, he or she can grab it there, thanks
[1] https://anongit.gentoo.org/git/proj/riscv.git

Comment 5 Andreas K. Hüttel archtester

2023-01-15 00:37:11 UTC

(In reply to Yixun Lan from comment #4)
> (In reply to Andreas Sturmlechner from comment #3)
> > Do not push this on your own without maintainer review please.
> > 
> > This is likely postponed for inclusion into a 7.4 release ebuild.
> 
> Ok, fair enough, then I will re-ping once the 7.4 release out
> 

7.4 is in and even going stable soon.

So I think this is the moment to start riscv keywording :) leaving the deps up to you...

Comment 6 Yixun Lan archtester

2023-02-10 22:53:42 UTC

there is merely a gentle ping..

for riscv64's patch, it didn't hit in 7.4 release, so I just skipped

and now it shows in 7.5.0.3, so I'd plan to give it a try..
would be great if @office can bump this new version, thanks

Comment 7 Andreas Sturmlechner gentoo-dev

2023-02-12 11:29:03 UTC

(In reply to Yixun Lan from comment #6)
> there is merely a gentle ping..
> 
> for riscv64's patch, it didn't hit in 7.4 release, so I just skipped
That's a bit confusing since you wanted to add a patch to 7.3 ;)

7.5.1.1 bump w/o KEYWORDS is in progress, we are not interested in the .0 release. riscv (and loong) may then go forth and keyword 7.5.x in advance of other arches which will remain on 7.4 for another release cycle.

Comment 8 Larry the Git Cow gentoo-dev

2023-02-12 11:50:26 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da3980c6a0aedf1b16e25a7917211c1ee3873981

commit da3980c6a0aedf1b16e25a7917211c1ee3873981
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-02-12 11:04:58 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-02-12 11:50:19 +0000

    app-office/libreoffice-l10n: add 7.5.0.3 w/o KEYWORDS
    
    Bug: https://bugs.gentoo.org/881389
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/libreoffice-l10n/Manifest               | 183 +++++++++++++++++++++
 .../libreoffice-l10n-7.5.0.3.ebuild                |  91 ++++++++++
 2 files changed, 274 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e958215b52f04a50324625e80e98d0b01a38db6c

commit e958215b52f04a50324625e80e98d0b01a38db6c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-02-12 10:57:16 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-02-12 11:50:18 +0000

    app-office/libreoffice: add 7.5.1.1 w/o KEYWORDS
    
    Bug: https://bugs.gentoo.org/881389
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/libreoffice/Manifest                   |   2 +
 app-office/libreoffice/libreoffice-7.5.1.1.ebuild | 653 ++++++++++++++++++++++
 2 files changed, 655 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77a438d00834dd115fa5d38fee59253ef9436de8

commit 77a438d00834dd115fa5d38fee59253ef9436de8
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-02-12 10:55:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-02-12 11:50:18 +0000

    app-office/libreoffice: add 7.5 stable branch
    
    Bug: https://bugs.gentoo.org/881389
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/libreoffice/libreoffice-7.5.9999.ebuild | 653 +++++++++++++++++++++
 1 file changed, 653 insertions(+)

Comment 9 NATTkA bot gentoo-dev

2023-02-12 11:56:28 UTC Comment hidden (obsolete)

Sanity check failed:

> app-office/libreoffice-7.4.5.1
>   depend ~riscv stable profile default/linux/riscv/20.0/rv64gc/lp64 (4 total)
>     >=app-text/libnumbertext-1.0.6
>     >=dev-cpp/libcmis-0.5.2-r2
>     >=dev-java/rhino-1.7.14:1.6
>     >=dev-libs/liborcus-0.17.2:0/0.17
>     >=games-engines/box2d-2.4.1:0
>     app-text/libstaroffice
>     dev-java/bsh
>     sci-libs/coinor-mp
>     sci-mathematics/lpsolve:=
>     sys-devel/ucpp
>   depend ~riscv dev profile default/linux/riscv/20.0/rv64gc/lp64/desktop (14 total)
>     >=app-text/libnumbertext-1.0.6
>     >=dev-cpp/libcmis-0.5.2-r2
>     >=dev-java/rhino-1.7.14:1.6
>     >=dev-libs/liborcus-0.17.2:0/0.17
>     >=games-engines/box2d-2.4.1:0
>     app-text/libstaroffice
>     dev-java/bsh
>     sci-libs/coinor-mp
>     sci-mathematics/lpsolve:=
>     sys-devel/ucpp
>   rdepend ~riscv stable profile default/linux/riscv/20.0/rv64gc/lp64 (4 total)
>     >=app-text/libnumbertext-1.0.6
>     >=dev-cpp/libcmis-0.5.2-r2
>     >=dev-java/rhino-1.7.14:1.6
>     >=dev-libs/liborcus-0.17.2:0/0.17
>     >=games-engines/box2d-2.4.1:0
>     app-text/libstaroffice
>     dev-java/bsh
>     sci-libs/coinor-mp
>     sci-mathematics/lpsolve:=
>   rdepend ~riscv dev profile default/linux/riscv/20.0/rv64gc/lp64/desktop (14 total)
>     >=app-text/libnumbertext-1.0.6
>     >=dev-cpp/libcmis-0.5.2-r2
>     >=dev-java/rhino-1.7.14:1.6
>     >=dev-libs/liborcus-0.17.2:0/0.17
>     >=games-engines/box2d-2.4.1:0
>     app-text/libstaroffice
>     dev-java/bsh
>     sci-libs/coinor-mp
>     sci-mathematics/lpsolve:=

Comment 10 WANG Xuerui gentoo-dev

2023-02-15 16:15:47 UTC

For the record, the 7.5.1.1 version wouldn't configure on loong due to missing adaptation in m4/ax_boost_base.m4. I'm able to workaround it temporarily and the build is continuing. autoconf-archive upstream PR made.

Comment 11 Yixun Lan archtester

2023-02-16 05:17:55 UTC

I've masked USE=java for app-office/libreoffice, which will pull in virtual/jdk:1.8 which isn't available on riscv, I probably will check if there is better solution later.

also update the package list

Comment 12 NATTkA bot gentoo-dev

2023-02-16 05:20:39 UTC Comment hidden (obsolete)

All sanity-check issues have been resolved

Comment 13 NATTkA bot gentoo-dev

2023-03-06 11:32:44 UTC Comment hidden (obsolete)

All sanity-check issues have been resolved

Comment 14 Yixun Lan archtester

2023-03-07 00:23:08 UTC

riscv done

Comment 15 NATTkA bot gentoo-dev

2023-03-12 21:16:29 UTC Comment hidden (obsolete)

Unable to check for sanity:

> no match for package: =app-office/libreoffice-7.5.1.2

Comment 16 Andreas Sturmlechner gentoo-dev

2023-03-12 21:17:59 UTC

Don't use fixed version for keywordreq, always assume latest unless specified.

Comment 17 NATTkA bot gentoo-dev

2023-03-12 21:21:08 UTC

All sanity-check issues have been resolved

Comment 18 Andreas Sturmlechner gentoo-dev

2023-04-08 21:20:34 UTC

loong fix went upstream in git commit 477374d8f5e3acfc2727b009a95427ef05297ffc.

Comment 19 Larry the Git Cow gentoo-dev

2023-04-08 22:56:29 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81d6e7ccdb312d17556cf969befc642a932a0dad

commit 81d6e7ccdb312d17556cf969befc642a932a0dad
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-04-08 21:40:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-04-08 22:55:27 +0000

    app-office/libreoffice: Backport loong fix from git master
    
    Upstream commit 477374d8f5e3acfc2727b009a95427ef05297ffc
    
    Bug: https://bugs.gentoo.org/881389
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-office/libreoffice/Manifest                    | 1 +
 app-office/libreoffice/libreoffice-7.5.2.2.ebuild  | 4 ++++
 app-office/libreoffice/libreoffice-7.5.9999.ebuild | 8 ++++++--
 3 files changed, 11 insertions(+), 2 deletions(-)

Comment 20 WANG Xuerui gentoo-dev

2023-04-11 19:19:09 UTC

loong done

Thank you very much for the heads-up and handling the backport!