Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881051 - gui-libs/wlroots-0.16.0: wlroots-0.15.1-tinywl-dont-crash-upon-missing-keyboard.patch fails to apply
Summary: gui-libs/wlroots-0.16.0: wlroots-0.15.1-tinywl-dont-crash-upon-missing-keyboa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Arthur Zamarin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-12 07:17 UTC by Kostadin Shishmanov
Modified: 2022-11-12 07:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
buildlog (build.log,2.96 KB, text/x-log)
2022-11-12 07:17 UTC, Kostadin Shishmanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kostadin Shishmanov 2022-11-12 07:17:09 UTC
Created attachment 831687 [details]
buildlog

Hunk #1 FAILED at 130.
1 out of 1 hunk FAILED -- saving rejects to file tinywl/tinywl.c.rej                                                                                                                                                                   [ !! ]
 * ERROR: gui-libs/wlroots-0.16.0::gentoo failed (prepare phase):
 *   patch -p1  failed with /var/tmp/portage/gui-libs/wlroots-0.16.0/files/wlroots-0.15.1-tinywl-dont-crash-upon-missing-keyboard.patch
 * 
 * Call stack:
 *               ebuild.sh, line  122:  Called src_prepare
 *             environment, line 2303:  Called default
 *      phase-functions.sh, line  872:  Called default_src_prepare
 *      phase-functions.sh, line  948:  Called __eapi8_src_prepare
 *             environment, line  365:  Called eapply '--' '/var/tmp/portage/gui-libs/wlroots-0.16.0/files/wlroots-0.15.1-tinywl-dont-crash-upon-missing-keyboard.patch'
 *             environment, line 1108:  Called _eapply_patch '/var/tmp/portage/gui-libs/wlroots-0.16.0/files/wlroots-0.15.1-tinywl-dont-crash-upon-missing-keyboard.patch'
 *             environment, line 1046:  Called __helpers_die 'patch -p1  failed with /var/tmp/portage/gui-libs/wlroots-0.16.0/files/wlroots-0.15.1-tinywl-dont-crash-upon-missing-keyboard.patch'
 *   isolated-functions.sh, line  112:  Called die
 * The specific snippet of code:
 *   		die "$@"
Comment 1 Kostadin Shishmanov 2022-11-12 07:17:26 UTC
cat /var/tmp/portage/gui-libs/wlroots-0.16.0/work/wlroots-0.16.0/tinywl/tinywl.c.rej 


--- tinywl/tinywl.c
+++ tinywl/tinywl.c
@@ -130,8 +130,10 @@ static void focus_view(struct tinywl_view *view, struct wlr_surface *surface) {
 	 * track of this and automatically send key events to the appropriate
 	 * clients without additional work on your part.
 	 */
-	wlr_seat_keyboard_notify_enter(seat, view->xdg_surface->surface,
-		keyboard->keycodes, keyboard->num_keycodes, &keyboard->modifiers);
+	if (keyboard != NULL) {
+		wlr_seat_keyboard_notify_enter(seat, view->xdg_surface->surface,
+			keyboard->keycodes, keyboard->num_keycodes, &keyboard->modifiers);
+	}
 }
Comment 2 Larry the Git Cow gentoo-dev 2022-11-12 07:21:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=507b29008b78d17849d35edcd3de596d5d7c6ce9

commit 507b29008b78d17849d35edcd3de596d5d7c6ce9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-11-12 07:20:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-12 07:21:12 +0000

    Revert "gui-libs/wlroots: add 0.16.0"
    
    This reverts commit 0df9b41880e83287a41e928c0719f1e97c91ae20.
    
    A patch doesn't apply and `pkgdiff -b` reveals several build system
    changes which may need adaptations in the ebuild.
    
    Closes: https://bugs.gentoo.org/881051
    Signed-off-by: Sam James <sam@gentoo.org>

 gui-libs/wlroots/Manifest              |  1 -
 gui-libs/wlroots/wlroots-0.16.0.ebuild | 83 ----------------------------------
 2 files changed, 84 deletions(-)