Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 881043 - app-crypt/acme, app-crypt/certbot and its modules: fix DistutilsNonPEP517Build & PythonGHDistfileSuffix
Summary: app-crypt/acme, app-crypt/certbot and its modules: fix DistutilsNonPEP517Buil...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-11-12 03:30 UTC by Thibaud CANALE
Modified: 2024-01-29 14:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud CANALE 2022-11-12 03:30:26 UTC
Current packages for Let’s Encrypt’s ACME & Certbot and also its modules could use some reworks to address those warnings or issues:
* pkgcheck raises as warnings DistutilsNonPEP517Build and PythonGHDistfileSuffix;
* multiple files are stored for the same and unique tar.gz archive.

We could then use some cohesion between packages to store and to handle one and single archive, saving storage and download.

Also, update the dependencies requirements to avoid incompatibilities.

Reproducible: Always
Comment 1 Thibaud CANALE 2023-02-02 20:58:10 UTC
Hi,

I recently pushed a new set of commits, it finally fixed the errors raised by QA.
Here right now I pushed after rebasing on current master, commit fc5296619222cc892f1106c0be9aa3206074e031.

It’s just four commits, i.e four packages with version up to 2.2.0:
app-crypt/acme
app-crypt/certbot-apache
app-crypt/certbot-nginx
app-crypt/certbot

I wish this could improve the burden of maintenance.
Comment 2 Thibaud CANALE 2023-02-16 00:09:41 UTC
Hello,

Rebased with version 2.3.0, current commit 4cf3fc6c10945ea3a0051f5bea9569e8953c220d.
Comment 3 Larry the Git Cow gentoo-dev 2023-02-16 15:57:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b7db97e1fac99ba15086e131f3d81ca3495f0b7

commit 3b7db97e1fac99ba15086e131f3d81ca3495f0b7
Author:     Thibaud CANALE <thican@thican.net>
AuthorDate: 2022-11-06 22:31:34 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2023-02-16 15:57:02 +0000

    app-crypt/certbot-nginx: brings multiple reworks (bug 881043)
    
    Bug: https://bugs.gentoo.org/881043
    
    The purpose of this rework is to use parent package archive as common
    base for all the modules.
    
    Warnings: some modifications might require some reviews, tests were done
    but maybe not thoroughly enough.
    
    Reworks:
      - replaces deprecated DISTUTILS_USE_SETUPTOOLS by
        DISTUTILS_USE_PEP517, with "setuptools" (DistutilsNonPEP517Build);
      - integrates parent mechanism for base source;
      - stores archive with ".gh" in its extension (PythonGHDistfileSuffix)
        also use parent’s file;
      - uses plaintext URL for SRC_URI;
      - common "S" path definition for live ebuild.
    
    Also removes zope since 2.0.0 version, see upstream commit
    9d736d5c9c939ef5a47b001ef9cb3ea97122c1c4:
    https://github.com/certbot/certbot/commit/9d736d5c9c939ef5a47b001ef9cb3ea97122c1c4
    
    Signed-off-by: Thibaud CANALE <thican@thican.net>
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 app-crypt/certbot-nginx/Manifest                   |  3 ++
 app-crypt/certbot-nginx/certbot-nginx-2.1.1.ebuild | 50 ++++++++++++++++++++++
 app-crypt/certbot-nginx/certbot-nginx-2.2.0.ebuild | 50 ++++++++++++++++++++++
 app-crypt/certbot-nginx/certbot-nginx-2.3.0.ebuild | 50 ++++++++++++++++++++++
 app-crypt/certbot-nginx/certbot-nginx-9999.ebuild  | 41 ++++++++++++------
 5 files changed, 181 insertions(+), 13 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a3a99c48d28c8243e2d785a15b84b525c36d2e3

commit 8a3a99c48d28c8243e2d785a15b84b525c36d2e3
Author:     Thibaud CANALE <thican@thican.net>
AuthorDate: 2022-11-06 15:27:32 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2023-02-16 15:57:01 +0000

    app-crypt/certbot-apache: brings multiple reworks (bug 881043)
    
    Bug: https://bugs.gentoo.org/881043
    
    The purpose of this rework is to use parent package archive as common
    base for all the modules.
    
    Warnings: some modifications might require some reviews, tests were done
    but maybe not thoroughly enough.
    
    Reworks:
      - replaces deprecated DISTUTILS_USE_SETUPTOOLS by
        DISTUTILS_USE_PEP517, with "setuptools" (DistutilsNonPEP517Build);
      - integrates parent mechanism for base source;
      - stores archive with ".gh" in its extension (PythonGHDistfileSuffix)
        also use parent’s file;
      - uses plaintext URL for SRC_URI;
      - common "S" path definition for live ebuild.
    
    Also removes zope since 2.0.0 version, see upstream commit
    9d736d5c9c939ef5a47b001ef9cb3ea97122c1c4:
    https://github.com/certbot/certbot/commit/9d736d5c9c939ef5a47b001ef9cb3ea97122c1c4
    
    Signed-off-by: Thibaud CANALE <thican@thican.net>
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 app-crypt/certbot-apache/Manifest                  |  3 ++
 .../certbot-apache/certbot-apache-2.1.1.ebuild     | 50 ++++++++++++++++++++++
 .../certbot-apache/certbot-apache-2.2.0.ebuild     | 50 ++++++++++++++++++++++
 .../certbot-apache/certbot-apache-2.3.0.ebuild     | 50 ++++++++++++++++++++++
 .../certbot-apache/certbot-apache-9999.ebuild      | 43 +++++++++++++------
 5 files changed, 183 insertions(+), 13 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51f64a7f8199962ad741caecf4668785dd7debbd

commit 51f64a7f8199962ad741caecf4668785dd7debbd
Author:     Thibaud CANALE <thican@thican.net>
AuthorDate: 2022-11-06 13:12:31 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2023-02-16 15:57:00 +0000

    app-crypt/certbot: brings multiple reworks (bug 881043)
    
    Bug: https://bugs.gentoo.org/881043
    
    The purpose of this commit is to provide a common base for this package
    and its bindings.
    For example, we should keep only one and single archive name to avoid
    duplication, saving storage and download time.
    
    Warnings: some modifications might require some reviews, tests were done
    but maybe not thorough.
    
    Reworks:
      - replaces deprecated DISTUTILS_USE_SETUPTOOLS by
        DISTUTILS_USE_PEP517, with "setuptools" (DistutilsNonPEP517Build);
      - stores archive with ".gh" in its extension (PythonGHDistfileSuffix);
      - uses plaintext URL for SRC_URI.
    
    Also removes zope since 2.0.0 version, see upstream commit
    9d736d5c9c939ef5a47b001ef9cb3ea97122c1c4:
    https://github.com/certbot/certbot/commit/9d736d5c9c939ef5a47b001ef9cb3ea97122c1c4
    
    Signed-off-by: Thibaud CANALE <thican@thican.net>
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 app-crypt/certbot/Manifest                |  3 ++
 app-crypt/certbot/certbot-2.1.1.ebuild    | 61 ++++++++++++++++++++++++++++++
 app-crypt/certbot/certbot-2.2.0-r2.ebuild | 62 +++++++++++++++++++++++++++++++
 app-crypt/certbot/certbot-2.3.0.ebuild    | 62 +++++++++++++++++++++++++++++++
 app-crypt/certbot/certbot-9999.ebuild     | 43 +++++++++++++++------
 5 files changed, 219 insertions(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=509cc952f54a75037180697612eee0e358da78a9

commit 509cc952f54a75037180697612eee0e358da78a9
Author:     Thibaud CANALE <thican@thican.net>
AuthorDate: 2022-11-06 14:39:50 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2023-02-16 15:56:59 +0000

    app-crypt/acme: brings multiple reworks (bug 881043)
    
    Bug: https://bugs.gentoo.org/881043
    
    The purpose of this rework is to use parent package archive as common
    base for all the modules.
    
    Warnings: some modifications might require some reviews, tests were done
    but maybe not thoroughly enough.
    
    Reworks:
      - replaces deprecated DISTUTILS_USE_SETUPTOOLS by
        DISTUTILS_USE_PEP517, with "setuptools" (DistutilsNonPEP517Build);
      - integrates parent mechanism for base source;
      - stores archive with ".gh" in its extension (PythonGHDistfileSuffix)
        also use parent’s file;
      - common "S" path definition for live ebuild.
    
    Signed-off-by: Thibaud CANALE <thican@thican.net>
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 app-crypt/acme/Manifest             |  3 ++
 app-crypt/acme/acme-2.1.1.ebuild    | 59 +++++++++++++++++++++++++++++++++++++
 app-crypt/acme/acme-2.2.0-r1.ebuild | 59 +++++++++++++++++++++++++++++++++++++
 app-crypt/acme/acme-2.3.0.ebuild    | 59 +++++++++++++++++++++++++++++++++++++
 app-crypt/acme/acme-9999.ebuild     | 34 ++++++++++++++++-----
 5 files changed, 207 insertions(+), 7 deletions(-)
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-01-29 14:01:48 UTC
There's a PEP517 ebuild now.