Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 880881 - sys-apps/pkgcore-0.12.17-r1 installs more files with FEATURES=test
Summary: sys-apps/pkgcore-0.12.17-r1 installs more files with FEATURES=test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PkgCore project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-11 08:39 UTC by Agostino Sarubbo
Modified: 2022-11-11 17:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-11 08:39:02 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/pkgcore-0.12.17-r1 installs more files with FEATURES=test.
Discovered on: amd64 (internal ref: ci)

NOTE:
To reproduce this issue:
1) Install the package with FEATURES=test
2) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist_test )
3) Install the package without FEATURES=test
4) Put the list of the installed files into a file ( qlist -e PACKAGE:SLOT | sort | uniq > /tmp/qlist_notest )
5) See the diff between the two files ( diff -ru /tmp/qlist_test /tmp/qlist_notest )

On this machine:
- the installed files with FEATURES=test are 1625
- the installed files without FEATURES=test are 1623

This type of report comes from a check that is a bit outside of the tinderbox, that's the reason because build.log was not provided (however in cases like these the build.log doesn't help much) but if you need further help to diagnose this issue feel free to ask.

In any case I'm providing a diff.
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-11 08:39:20 UTC
DIFF:
--- /dev/fd/63  2022-11-11 00:32:47.882491812 +0100
+++ /dev/fd/62  2022-11-11 00:32:47.882491812 +0100
@@ -220,6 +220,8 @@
 /usr/lib/pkgcore/ebd/.generated/libs/8/src_prepare
 /usr/lib/pkgcore/ebd/.generated/libs/8/src_test
 /usr/lib/pkgcore/ebd/.generated/libs/8/src_unpack
+/usr/lib/pkgcore/ebd/.generated/libs/test1/global
+/usr/lib/pkgcore/ebd/.generated/libs/test/global
 /usr/lib/pkgcore/ebd/generate_eapi_cmd_list
 /usr/lib/pkgcore/ebd/generate_eapi_func_list
 /usr/lib/pkgcore/ebd/generate_eapi_lib
Comment 2 Larry the Git Cow gentoo-dev 2022-11-11 17:33:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pkgcore/pkgcore.git/commit/?id=9bf28884e787402e63b94c5450c1a4af98623220

commit 9bf28884e787402e63b94c5450c1a4af98623220
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2022-11-11 17:28:09 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-11-11 17:28:09 +0000

    ebuild/test_eapi.py: fix test_register artifacts
    
    test_register was leaving behind a bunch of files in the EBD_PATH, which
    might pollute installation or venv. Create a temporary directory, into
    which the ebd is copied and redirected for the duration of the test.
    
    Bug: https://bugs.gentoo.org/880881
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 tests/ebuild/test_eapi.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2022-11-11 17:33:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad80bcbb0fb4b7ddca33a27f7f450fd6baa2cf54

commit ad80bcbb0fb4b7ddca33a27f7f450fd6baa2cf54
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2022-11-11 17:33:06 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2022-11-11 17:33:42 +0000

    sys-apps/pkgcore: fix test artifacts being installed
    
    Closes: https://bugs.gentoo.org/880881
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 .../files/pkgcore-0.12.17-fix-extra-files.patch    | 29 ++++++++++++++++++++++
 ...0.12.17-r1.ebuild => pkgcore-0.12.17-r2.ebuild} |  1 +
 2 files changed, 30 insertions(+)