When trying to view (F3) a videofile in Midnight Commander and it can't locate a program to extract information with, it shows a message saying you need to have mplayer or mpv installed; however, the file that it's looking for (in case of mpv) is `mpv_identify.sh`, which is only installed with mpv when the `tools` USE flag is enabled. Thus, anyone who has mpv installed without `+tools` will see a confusing message suggesting to install mpv. Reproducible: Always Steps to Reproduce: 1. Have `app-misc/mc` installed (without `media-video/mplayer` or `media-video/mpv +tools`), with default configuration for handling videofiles 2. Run `mc` and navigate to a videofile (e.g. an MP4 file) 3. Press F3 to view the file Actual Results: The viewer contains the following message: `Please install either mplayer or mpv to get information for this file` Expected Results: The message should clarify that mpv should be installed with `+tools` USE flag. The file containing the message is `/usr/libexec/mc/ext.d/video.sh`; there should be no problem in patching it during the installation.
This is Gentoo-specific so we cannot really bring it upstream. Our only options would be to patch /usr/libexec/mc/ext.d/video.sh and replace the current message's 'mpv' with 'mpv[tools]'.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b77588e1eca99bfa6f72fa241cbe6107a85984c commit 2b77588e1eca99bfa6f72fa241cbe6107a85984c Author: Marek Szuba <marecki@gentoo.org> AuthorDate: 2023-01-24 10:08:53 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2023-01-24 11:00:44 +0000 app-misc/mc: add 4.8.29 Closes: https://bugs.gentoo.org/880755 Signed-off-by: Marek Szuba <marecki@gentoo.org> app-misc/mc/Manifest | 1 + app-misc/mc/files/mc-4.8.29-gentoo-tools.patch | 11 +++ app-misc/mc/mc-4.8.29.ebuild | 126 +++++++++++++++++++++++++ 3 files changed, 138 insertions(+)
