Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 880737 - media-video/mpv-0.34.1_p20221105 fails to build if gnustep-base/gnustep-gui installed
Summary: media-video/mpv-0.34.1_p20221105 fails to build if gnustep-base/gnustep-gui i...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ionen Wolkens
URL: https://github.com/mpv-player/mpv/iss...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-10 12:49 UTC by Daniel Dawson
Modified: 2022-11-11 17:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,21.89 KB, text/plain)
2022-11-10 12:49 UTC, Daniel Dawson
Details
Build log (build.log,12.30 KB, text/plain)
2022-11-10 12:50 UTC, Daniel Dawson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Dawson 2022-11-10 12:49:40 UTC
Created attachment 830277 [details]
emerge --info

If I have gnustep-gui installed, the following appears in the build log:

Checking if "macos-touchbar check" compiles: YES
...
meson.build:1664:4: ERROR: No host machine compiler for 'osdep/macosx_touchbar.m'

The check consists of a small Objective-C program using NSTouchBar. Strange that it's able to compile that, but then later it can't find the compiler.

I tried configuring by hand with "meson setup -Dmacos-touchbar=disabled", but it detects and enables it anyway, while also skipping another thing that depends on it.

This doesn't happen with version 0.34.1-r1, which appears to have a different build process.
Comment 1 Daniel Dawson 2022-11-10 12:50:48 UTC
Created attachment 830279 [details]
Build log
Comment 2 Ionen Wolkens gentoo-dev 2022-11-11 00:24:13 UTC
Yeah, I see it provides AppKit/AppKit.h which let the test pass and disabling the option indeed doesn't help.

Could you report this meson.build issue upstream too? I'll see to work around it here but it is not specifically an ebuild issue.
Comment 3 Larry the Git Cow gentoo-dev 2022-11-11 00:47:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fb1614a93bdb50808a6de8cec2da308184bb85c

commit 7fb1614a93bdb50808a6de8cec2da308184bb85c
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-11-11 00:36:01 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-11 00:45:58 +0000

    media-video/mpv: fix build when gnustep-gui is installed
    
    quick fix by ensuring macos_touchbar['deps'].found()
    ('and' check is fine there, right? .. well it works)
    
    Closes: https://bugs.gentoo.org/880737
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 media-video/mpv/files/mpv-0.34.1_p20221105-macos-touchbar.patch | 8 ++++++++
 media-video/mpv/mpv-0.34.1_p20221105.ebuild                     | 4 ++++
 media-video/mpv/mpv-9999.ebuild                                 | 4 ++++
 3 files changed, 16 insertions(+)
Comment 4 Daniel Dawson 2022-11-11 17:16:55 UTC
Upstream: https://github.com/mpv-player/mpv/issues/10847
Comment 5 Ionen Wolkens gentoo-dev 2022-11-11 17:30:10 UTC
Thanks!