https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: sys-fs/cryfs-0.10.3-r1 fails to compile (LTO-SYSTEM). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: (LTO-SYSTEM) in the summary means that bug was found on a machine that runs lto but this bug MAY or MAY NOT BE related to lto. This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 829939 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: test/blobstore/blobstore-test /var/tmp/portage/sys-fs/cryfs-0.10.3-r1/work/test/blobstore/implementations/onblocks/datanodestore/DataLeafNodeTest.cpp:261:8: error: type ‘struct DataRange’ violates the C++ One Definition Rule [-Werror=odr]
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f8274eda8c1723e48a5dcad429724ea01ec4862 commit 1f8274eda8c1723e48a5dcad429724ea01ec4862 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-06-27 07:06:12 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-06-27 07:06:23 +0000 sys-fs/cryfs: fix python-any-r1 usage Closes: https://bugs.gentoo.org/908997 Closes: https://bugs.gentoo.org/880563 Signed-off-by: Sam James <sam@gentoo.org> sys-fs/cryfs/cryfs-0.10.3-r1.ebuild | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19a3b024ad4252574c2a4b5de394f1d102544556 commit 19a3b024ad4252574c2a4b5de394f1d102544556 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-02-28 22:55:50 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-28 22:57:01 +0000 sys-fs/cryfs: filter LTO (ODR violations) Closes: https://bugs.gentoo.org/880563 Signed-off-by: Sam James <sam@gentoo.org> sys-fs/cryfs/cryfs-0.10.3-r1.ebuild | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
