Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 880183 - games-rpg/freedink has incorrect LICENSE
Summary: games-rpg/freedink has incorrect LICENSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-07 09:38 UTC by ganooslashlinus
Modified: 2022-11-08 05:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ganooslashlinus 2022-11-07 09:38:06 UTC
LICENSE="GPL-3"

debian/copyright:
...
This file is part of GNU FreeDink

    GNU FreeDink is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
...
FreeDink includes vgasys.fon (from Wine), cf. src/vgasys_fon.c.

    This library is free software; you can redistribute it and/or modify
    it under the terms of the GNU Lesser General Public License as
    published by the Free Software Foundation; either version 2.1 of the
    License, or (at your option) any later version.
...

The gnulib directory is an embedded copy of gnulib:

License:

        GNULib is a collection of unrelated source files. Each source file is
        provided under a different license (including GPL, LGPL, GFDL and
        others) and includes a license headers stating the terms that apply to
        that particular file.
...

gnulib contains a few files that are GPLv2-or-later.

Also, src/binreloc.c is public domain.


Therefore, it should be: LICENSE="GPLv3+ LGPLv2.1+ public-domain"
Comment 1 Ionen Wolkens gentoo-dev 2022-11-07 15:29:24 UTC
Thanks, I'll have a look at that ebuild a bit later for other things too -- it's a bit rotting.
Comment 2 Larry the Git Cow gentoo-dev 2022-11-08 05:37:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92561523ab995f58eec490f9da3962ad661b9e2f

commit 92561523ab995f58eec490f9da3962ad661b9e2f
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-11-08 00:58:19 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-08 05:36:54 +0000

    games-rpg/freedink: add 109.6
    
    Now uses SDL2.
    
    ebuild changes:
    * EAPI6->8
    * fix licenses wrt bug #880183 (minus public-domain, binreloc.c
      is not in this version)
    * update HOMEPAGE, old domain seems dead
    * tentatively drop -O? -> -O0 replace-flags, many changes including
      using C++ and hopefully is not relevant anymore (or at least, I can
      load save games even with -O3)
      -> also drop filter-flags, it had no arguments and was no-op
        (likely was meant to be strip-flags)
    * change windres workaround to not need a patch
    
    (note it gives a misleading error about lacking Ogg support, but
    if look at debug output it successfully finds Ogg differently)
    
    Closes: https://bugs.gentoo.org/880183
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 games-rpg/freedink/Manifest                       |  1 +
 games-rpg/freedink/files/freedink-109.6-odr.patch | 14 +++++++
 games-rpg/freedink/files/freedink-109.6-sdl.patch | 20 +++++++++
 games-rpg/freedink/freedink-109.6.ebuild          | 50 +++++++++++++++++++++++
 4 files changed, 85 insertions(+)