Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879877 - x11-wm/fvwm3-9999 respect vanilla USE flag patch
Summary: x11-wm/fvwm3-9999 respect vanilla USE flag patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matt Jolly
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2022-11-05 14:39 UTC by needle
Modified: 2023-03-15 05:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix vanilla USE flag (patch,917 bytes, patch)
2022-11-05 14:40 UTC, needle
Details | Diff
fix2 vanilla USE flag (patch,917 bytes, patch)
2022-11-05 14:44 UTC, needle
Details | Diff
translucent menu patch fails in git (20221205_fvwm3_translucent_menus_patch.log,4.75 KB, text/x-log)
2022-12-05 10:39 UTC, needle
Details

Note You need to log in before you can comment on or make changes to this bug.
Description needle 2022-11-05 14:39:07 UTC
The current fvwm3 ebuild does not apply the vanilla USE flag, if vanilla is enabled.

Reproducible: Always

Steps to Reproduce:
1. enable vanilla USE flag
2. emerge fvwm3
3. 
Actual Results:  
Optional patches like translucent menus are enable even when vanilla USE flag is enabled.

Expected Results:  
Optional fvwm3 patches should not applied when vanilla USE flag is enabled.
Comment 1 needle 2022-11-05 14:40:32 UTC
Created attachment 827823 [details, diff]
fix vanilla USE flag

vanilla USE flag ebuild patch added
Comment 2 needle 2022-11-05 14:44:54 UTC
Created attachment 827825 [details, diff]
fix2 vanilla USE flag

Screwed up the inital patch. Uploaded the correct version of the patch.
Comment 3 needle 2022-12-05 10:39:08 UTC
Created attachment 840199 [details]
translucent menu patch fails in git
Comment 4 needle 2022-12-05 10:39:40 UTC
Meanwhile the translucent menu patch does not apply to the current HEAD.
(check attached build.log)

vanilla USE flag enabled, but patch gets applied.

Any chance to fix this and make the USE flags working properly again in this ebuild?

Thanks in advance.
Comment 5 Larry the Git Cow gentoo-dev 2023-03-15 05:04:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=48a2217b5bc9205569152461cccaac20e20306d5

commit 48a2217b5bc9205569152461cccaac20e20306d5
Author:     Matt Jolly <Matt.Jolly@footclan.ninja>
AuthorDate: 2023-03-12 04:28:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-15 05:04:16 +0000

    x11-wm/fvwm3: add 1.0.6a, update 9999
    
    - Drop translucent menu patch; after 20 years it was upstreamed!
    - Drop htmldoc patch
    - Drop vanilla USE; superfluous
    
    Closes: https://bugs.gentoo.org/877487
    Closes: https://bugs.gentoo.org/879877
    
    Signed-off-by: Matt Jolly <Matt.Jolly@footclan.ninja>
    Closes: https://github.com/gentoo/gentoo/pull/30066
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-wm/fvwm3/Manifest                              |   1 +
 x11-wm/fvwm3/files/fvwm3-9999-goflags.patch        |  11 -
 x11-wm/fvwm3/files/fvwm3-9999-htmldoc.patch        |  43 --
 .../fvwm3/files/fvwm3-9999-translucent-menus.patch | 489 ---------------------
 x11-wm/fvwm3/fvwm3-1.0.6a.ebuild                   | 167 +++++++
 x11-wm/fvwm3/fvwm3-9999.ebuild                     |  44 +-
 x11-wm/fvwm3/metadata.xml                          |   1 +
 7 files changed, 185 insertions(+), 571 deletions(-)