Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879855 - >=www-client/firefox-106.0 fails to compile for armv7 with: Error: .size expression for ff_fft_calc_neon does not evaluate to a constant
Summary: >=www-client/firefox-106.0 fails to compile for armv7 with: Error: .size expr...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-05 10:22 UTC by tt_1
Modified: 2022-11-08 17:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
output from emerge --info (armv7) (emerge-info,5.33 KB, text/plain)
2022-11-05 10:23 UTC, tt_1
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2022-11-05 10:22:49 UTC
from the build log:

17452733-29:43.81 /var/tmp/portage/www-client/firefox-106.0.4/temp/ccErViv6.s: Assembler messages:
17452823:29:43.81 /var/tmp/portage/www-client/firefox-106.0.4/temp/ccErViv6.s: Error: .size expression for ff_fft_calc_neon does not evaluate to a constant
17452970:29:43.81 /var/tmp/portage/www-client/firefox-106.0.4/temp/ccErViv6.s: Error: .size expression for ff_fft_permute_neon does not evaluate to a constant
17453120-29:43.81 gmake[4]: *** [/var/tmp/portage/www-client/firefox-106.0.4/work/firefox-106.0.4/config/rules.mk:664: fft_neon.o] Error 1
17453250-29:43.81 gmake[4]: Leaving directory '/var/tmp/portage/www-client/firefox-106.0.4/work/firefox_build/media/ffvpx/libavcodec/arm'


emerge -pv firefox

[ebuild   R   *] www-client/firefox-106.0.4:rapid::gentoo to /usr/armv7a-unknown-linux-gnueabihf/ USE="X hwaccel system-harfbuzz system-icu system-jpeg system-libevent system-png system-webp -clang -dbus -debug (-eme-free) -geckodriver -gmp-autoupdate -hardened -jack -libproxy -lto -openh264 (-pgo) -pulseaudio -screencast (-selinux) -sndio -system-av1 -system-libvpx -wayland -wifi" CPU_FLAGS_ARM="neon" 0 KiB
Comment 1 tt_1 2022-11-05 10:23:29 UTC
Created attachment 827751 [details]
output from emerge --info (armv7)
Comment 2 tt_1 2022-11-05 10:29:52 UTC
current fix is to set USE="+system-libvpx" 

I thought this was the fix

https://github.com/FFmpeg/FFmpeg/commit/f99d15cca0f6ceedb4f2f38d67a52dacc9556fc7

but sadly it didn't fix it when backported to the firefox-106.0.4 source
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-06 06:08:52 UTC
Can you report this upstream please (to firefox)?
Comment 4 Joonas Niilola gentoo-dev 2022-11-06 06:50:13 UTC
Any idea if 102 works / doesn't work? I think -system-libvpx is also broken in x86 so the +system-libvpx use flag is always forced on x86. We can do similar for arm.
Comment 6 tt_1 2022-11-06 17:50:18 UTC
(In reply to Joonas Niilola from comment #4)
> Any idea if 102 works / doesn't work? I think -system-libvpx is also broken
> in x86 so the +system-libvpx use flag is always forced on x86. We can do
> similar for arm.

the corresponding bug states that 102esr is not affected by it
Comment 7 tt_1 2022-11-08 13:55:25 UTC
I just finished compiling firefox-106.0.5 with the patch, can confirm it fixing and working. Care to add it the 106-patchset? Its still a week for the release of 107.0, and probaly 10-14 days untill the ebuild hits the tree.
Comment 8 Joonas Niilola gentoo-dev 2022-11-08 14:10:38 UTC
Maybe if I get another chance to compile firefox before that... got too much to do anyway. But I do ask myself: why do we carry arm patches when firefox isn't keyworded for arm in gentoo? Maybe you want some overlay that includes all arm-specific patches on top of our ebuild?
Comment 9 tt_1 2022-11-08 14:37:45 UTC
(In reply to Joonas Niilola from comment #8)
> Maybe if I get another chance to compile firefox before that... got too much
> to do anyway. 

take all the time that you need, I'm all in if you want to focus on supporting llvm-15 

> But I do ask myself: why do we carry arm patches when firefox
> isn't keyworded for arm in gentoo? 

keywording is relativ on arm, many many packages actually lack them. 

I also do my best to catch any arm regression in nightly, therefore its only one arm specific upstream patch at the moment in the patchset, which is from a third_party source (libyuv) - once that third_party patch is fixed it will be down to none. 

There is one gentoo specific patch about libaom, which is a minimal invasive one liner, and I'd rather get rid of libaom as its painfull to deal with all of its neon breakages. This day will come, but its not today and not tomorrow (see mozbg 1789986)
Comment 10 Larry the Git Cow gentoo-dev 2022-11-08 17:20:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c755e10851c075aff8dbcdbdc81c014f7df8e50

commit 0c755e10851c075aff8dbcdbdc81c014f7df8e50
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-11-08 17:19:39 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-11-08 17:19:39 +0000

    www-client/firefox: add a patch to fix building on arm on 106.0.5
    
    Closes: https://bugs.gentoo.org/879855
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/firefox/Manifest               | 2 +-
 www-client/firefox/firefox-106.0.5.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)