Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879797 - net-misc/turbovnc: possible configure breakage with Clang 16
Summary: net-misc/turbovnc: possible configure breakage with Clang 16
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Viorel Munteanu
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 906027
  Show dependency tree
 
Reported: 2022-11-04 23:10 UTC by Matt Jolly
Modified: 2023-05-12 04:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
clang-14 log (clang-14.log,9.21 KB, text/x-log)
2022-11-04 23:10 UTC, Matt Jolly
Details
clang-15 log (clang-15.log,9.19 KB, text/x-log)
2022-11-04 23:10 UTC, Matt Jolly
Details
clang.diff (clang.diff,13.16 KB, patch)
2022-11-04 23:10 UTC, Matt Jolly
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Jolly gentoo-dev 2022-11-04 23:10:04 UTC
Created attachment 827655 [details]
clang-14 log

This package has been identified via automation as potentially impacted by upcoming Clang 16 changes.
The following have been identified as potential issues:

[-Werror,-Wimplicit-function-declaration]

[-Werror,-Wimplicit-function-declaration]
error: call to undeclared library function 'strlcat' with type 'unsigned long (char *, const char *, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
error: call to undeclared library function 'strlcpy' with type 'unsigned long (char *, const char *, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
Comment 1 Matt Jolly gentoo-dev 2022-11-04 23:10:27 UTC
Created attachment 827657 [details]
clang-15 log
Comment 2 Matt Jolly gentoo-dev 2022-11-04 23:10:43 UTC
Created attachment 827659 [details, diff]
clang.diff
Comment 3 Viorel Munteanu gentoo-dev 2022-11-05 09:50:13 UTC
I looked at the diff.  It is true clang-14 gives a warning while clang-15 gives an error, but they both fail afterwards at link time (the functions in question do not exist by default, they are in <bsd/string.h> and -lbsd).  So in this case the functions are not implicitly declared, they are simply missing.

Also if the functions did exist, `check_symbol_exists` has an include file, so they would both succeed.
Comment 4 Larry the Git Cow gentoo-dev 2023-05-12 04:40:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de291e9ee855a904ec9f56d1339d0be7a464a2a2

commit de291e9ee855a904ec9f56d1339d0be7a464a2a2
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2023-05-10 07:53:21 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-05-12 04:34:46 +0000

    net-misc/turbovnc: fix clang-16 warning QA check
    
    Ignore BSD-only functions.
    
    Closes: https://bugs.gentoo.org/879797
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 net-misc/turbovnc/turbovnc-3.0.3.ebuild | 3 +++
 1 file changed, 3 insertions(+)