Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 879111 - dev-games/godot-4.0_beta4 fails to compile: glslang_resource_limits.h:145:1: error: cannot convert <brace-enclosed initializer list> to int in initialization
Summary: dev-games/godot-4.0_beta4 fails to compile: glslang_resource_limits.h:145:1: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ionen Wolkens
URL: https://github.com/KhronosGroup/glsla...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-02 06:21 UTC by Agostino Sarubbo
Modified: 2022-11-02 10:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,163.85 KB, text/plain)
2022-11-02 06:21 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-11-02 06:21:23 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-games/godot-4.0_beta4 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-11-02 06:21:25 UTC
Created attachment 826595 [details]
build.log

build log and emerge --info
Comment 2 Ionen Wolkens gentoo-dev 2022-11-02 06:40:44 UTC
Looks caused by glslang-1.3.231 that got pushed bit earlier, was still on 1.3.224 when I tested (likely all godot versions are broken now).

I'll have a look likely tomorrow, worst case I could temporarily fallback to bundled glslang which is more what upstream supports.
Comment 3 Ionen Wolkens gentoo-dev 2022-11-02 06:50:27 UTC
(In reply to Ionen Wolkens from comment #2)
> Looks caused by glslang-1.3.231 that got pushed bit earlier, was still on
> 1.3.224 when I tested (likely all godot versions are broken now).
> 
> I'll have a look likely tomorrow, worst case I could temporarily fallback to
> bundled glslang which is more what upstream supports.
From a quick look modules/glslang/glslang_resource_limits.h uses part of the private API and needs to be sync'ed with files that aren't installed by glslang.

So bundled may be the way to go if that's how it's going to be.
Comment 4 Larry the Git Cow gentoo-dev 2022-11-02 07:33:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=badc538a3013607d16632ca551697b3eb462bd74

commit badc538a3013607d16632ca551697b3eb462bd74
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2022-11-02 06:56:01 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2022-11-02 07:32:41 +0000

    dev-games/godot: switch to bundled glslang+vulkan-headers
    
    Similarly to pcsx2, this uses part of the glslang private API
    and can break easily with the system's copy. Also use bundled
    vulkan-headers given mismatching with glslang is also volatile.
    
    Revbump given it could've built with the old glslang and possibly
    have ill effects after updating it.
    
    Closes: https://bugs.gentoo.org/879111
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 ...godot-4.0_beta4.ebuild => godot-4.0_beta4-r1.ebuild} | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
Comment 5 Ionen Wolkens gentoo-dev 2022-11-02 08:14:15 UTC
Still leaving re-using system's on the table depending on where $URL goes as TBuiltInResource is what caused this and the ABI issues seem to be worse than the build failures we get here.

Not that I'm going to worry too much about this during _beta*