Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878891 - sci-libs/lapack-3.10.1 fails to compile (lto): c_sblat3.f:284:72: error: type of cs3chke does not match original declaration [-Werror=lto-type-mismatch]
Summary: sci-libs/lapack-3.10.1 fails to compile (lto): c_sblat3.f:284:72: error: type...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-10-31 16:30 UTC by Agostino Sarubbo
Modified: 2024-03-04 05:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,64.96 KB, application/x-xz)
2022-10-31 16:31 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-10-31 16:30:58 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/lapack-3.10.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-10-31 16:31:02 UTC
Created attachment 826237 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-10-31 16:31:04 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: bin/xdcblat3 
FAILED: bin/xscblat3 
/var/tmp/portage/sci-libs/lapack-3.10.1/work/lapack-3.10.1/CBLAS/testing/c_sblat3.f:284:72: error: type of ‘cs3chke’ does not match original declaration [-Werror=lto-type-mismatch]
Comment 3 Larry the Git Cow gentoo-dev 2024-02-28 15:27:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91b7a7537de9f4c49d9ef8abb6eaba2b0fbbe79b

commit 91b7a7537de9f4c49d9ef8abb6eaba2b0fbbe79b
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-02-28 06:28:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-28 15:26:27 +0000

    sci-libs/lapack: mark as LTO-unsafe
    
    Bug: https://bugs.gentoo.org/878891
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/lapack/lapack-3.11.ebuild   | 9 +++++++--
 sci-libs/lapack/lapack-3.12.0.ebuild | 7 ++++++-
 2 files changed, 13 insertions(+), 3 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2024-03-03 04:00:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58d080c1bad9b1c0d307f2cf2d0251d60025efb1

commit 58d080c1bad9b1c0d307f2cf2d0251d60025efb1
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-03 03:47:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-03 04:00:13 +0000

    sci-libs/lapack: backport 64-bit API fix detected by LTO warnings
    
    https://github.com/Reference-LAPACK/lapack/issues/990#issuecomment-1973258284
    
    Bug: https://bugs.gentoo.org/878891
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../lapack-3.12.0-correct-64bit-interface.patch    |  38 +++++++
 sci-libs/lapack/lapack-3.12.0-r1.ebuild            | 115 +++++++++++++++++++++
 2 files changed, 153 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2024-03-04 05:20:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb7d223bb97be7db2af28d511e2342d45d59211e

commit fb7d223bb97be7db2af28d511e2342d45d59211e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-04 05:20:07 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-04 05:20:40 +0000

    sci-libs/lapack: restore filter-lto
    
    In 58d080c1bad9b1c0d307f2cf2d0251d60025efb1, we dropped filter-lto, but
    the testsuite still fails to build with LTO, so put it back.
    
    Bug: https://bugs.gentoo.org/878891
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/lapack/lapack-3.12.0-r1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)