https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-vcs/pre-commit-2.20.0-r1 fails tests. Discovered on: amd64 (internal ref: ci)
Created attachment 826093 [details] build.log build log and emerge --info
Created attachment 826095 [details] 1-test.log 1-test.log
Error(s) that match a know pattern: E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_get_conflicted_files_in_s0/1', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_install_in_submodule_and_0/2', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_is_in_merge_conflict_subm0/1', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_submodule_does_not_discar0/0', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_submodule_does_not_discar1/0', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_sub_nothing_unstaged0/0', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_sub_something_unstaged0/0', 'sub') E pre_commit.util.CalledProcessError: command: ('/usr/bin/git', 'submodule', 'add', '/var/tmp/portage/dev-vcs/pre-commit-2.20.0-r1/temp/pytest-of-portage/pytest-0/test_sub_staged0/0', 'sub') FAILED tests/commands/install_uninstall_test.py::test_install_in_submodule_and_run
This is triggered by a recent security patch in dev-vcs/git. I wonder if we need a tracker for those.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=96238e309ddbd3f6aca08d59c9db543a67be67c9 commit 96238e309ddbd3f6aca08d59c9db543a67be67c9 Author: Marek Szuba <marecki@gentoo.org> AuthorDate: 2022-11-13 22:26:10 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2022-11-13 22:34:16 +0000 dev-vcs/pre-commit: allow the tests to use the 'file' transport Needed for the test suite to work against git versions including the fix for CVE-2022-39253. Should be harmless enough even if upstream gets compromised and publishes a tarball containing malicious symlinks, unless someone makes a serious effort to grant Portage a lot of unnecessary privileges. Closes: https://bugs.gentoo.org/878781 Signed-off-by: Marek Szuba <marecki@gentoo.org> ...re-commit-2.20.0-tests_git_file_transport.patch | 44 ++++++++++++++++++++++ dev-vcs/pre-commit/pre-commit-2.20.0-r1.ebuild | 1 + 2 files changed, 45 insertions(+)
