Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878677 - dev-vcs/pre-commit still requires dev-python/toml
Summary: dev-vcs/pre-commit still requires dev-python/toml
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Marek Szuba (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 881279
Blocks: 878651
  Show dependency tree
 
Reported: 2022-10-29 13:29 UTC by Michał Górny
Modified: 2022-11-15 08:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-10-29 13:29:21 UTC
See tracker.

Upstream is opposed to using toml (and also bans people for daring mention tomli), so I guess we're just going to lastrite this package when the time comes.  It'd be probably for the best, given how toxic the author is.
Comment 1 Marek Szuba (RETIRED) archtester gentoo-dev 2022-10-29 14:53:32 UTC
Upstream dropped toml dependency literally today, see commit e703982de45ac64492897b25fa4edbdb8da10e62. Will see if backfiring this works, if not hopefully there will be a new release soon enough.
Comment 2 Larry the Git Cow gentoo-dev 2022-10-30 00:31:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37fe831d60f51bd1d43c3ff6c34510e78d99ade4

commit 37fe831d60f51bd1d43c3ff6c34510e78d99ade4
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-10-30 00:28:19 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-10-30 00:31:38 +0000

    dev-vcs/pre-commit: drop dependency on dev-python/toml
    
    Backported to 2.20.0 from upstream Git master branch.
    
    Bug: https://bugs.gentoo.org/878677
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 dev-vcs/pre-commit/Manifest                        |  1 +
 .../files/pre-commit-2.20.0-no_toml.patch          | 81 ++++++++++++++++++++++
 dev-vcs/pre-commit/pre-commit-2.20.0-r1.ebuild     | 54 +++++++++++++++
 3 files changed, 136 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-11-15 08:58:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dea058cc176b290223a151c4e5f32ea0f064c94a

commit dea058cc176b290223a151c4e5f32ea0f064c94a
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-11-15 08:57:56 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-11-15 08:58:08 +0000

    dev-vcs/pre-commit: drop ebuilds depending on dev-python/toml
    
    Closes: https://bugs.gentoo.org/878677
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 dev-vcs/pre-commit/Manifest                 |  1 -
 dev-vcs/pre-commit/pre-commit-2.20.0.ebuild | 51 -----------------------------
 2 files changed, 52 deletions(-)