Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878401 - app-admin/sudo-1.9.12 on mips: ./exec_ptrace.c:302:22: error: ‘iov’ undeclared (first use in this function)
Summary: app-admin/sudo-1.9.12 on mips: ./exec_ptrace.c:302:22: error: ‘iov’ undeclare...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: MIPS Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/sudo-project/sudo/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-26 20:56 UTC by matoro
Modified: 2022-10-28 20:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (file_878401.txt,165.87 KB, text/plain)
2022-10-26 20:58 UTC, matoro 		Details
emerge --info (file_878401.txt,5.75 KB, text/plain)
2022-10-26 20:59 UTC, matoro 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description matoro archtester 2022-10-26 20:56:43 UTC 
app-admin/sudo-1.9.12 fails to compile on mips.  Appears to be due to this upstream commit:  https://github.com/sudo-project/sudo/commit/3d995f7e58a38b42b41ba94026e2b7a3042d9df4

There is a comment explaining the reason for the mips-specific code:  /* PTRACE_GETREGSET has bugs with the MIPS o32 ABI at least. */

mips64-unknown-linux-gnu-gcc -c -I../include -I.. -I. -I. -D_PATH_SUDO_CONF=\"/etc/sudo.conf\" -DLOCALEDIR=\"/usr/share/locale\" -DZLIB_CONST -O3 -pipe -march=native -mtune=native -mabi=64 -fvisibility=hidden  -fPIE  ./exec_ptrace.c
./exec_ptrace.c: In function ‘ptrace_getregs’:
./exec_ptrace.c:302:22: error: ‘iov’ undeclared (first use in this function)
  302 |             compat = iov.iov_len != sizeof(regs->u.native);
      |                      ^~~
./exec_ptrace.c:302:22: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:666: exec_ptrace.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/var/tmp/portage/app-admin/sudo-1.9.12/work/sudo-1.9.12/src'
make: *** [Makefile:110: all] Error 2

Reproducible: Always
Comment 1 matoro archtester 2022-10-26 20:58:29 UTC 
Created attachment 825535 [details]
build.log
Comment 2 matoro archtester 2022-10-26 20:59:06 UTC 
Created attachment 825537 [details]
emerge --info
Comment 3 matoro archtester 2022-10-26 23:52:21 UTC 
Fixed by upstream very quickly!  https://github.com/sudo-project/sudo/commit/7944494196d4a9b33e0ae64a7e20f86e19c336d3
Comment 4 Larry the Git Cow gentoo-dev 2022-10-28 20:11:42 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73fc86d879db42a9ce5a4ef9b73f088b02551169

commit 73fc86d879db42a9ce5a4ef9b73f088b02551169
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-28 20:11:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-28 20:11:14 +0000

    app-admin/sudo: backport MIPS patch
    
    Closes: https://bugs.gentoo.org/878401
    Signed-off-by: Sam James <sam@gentoo.org>

 app-admin/sudo/files/sudo-1.9.12-mips-build.patch | 33 +++++++++++++++++++++++
 app-admin/sudo/sudo-1.9.12.ebuild                 |  4 +++
 2 files changed, 37 insertions(+)